Bug 1467007
| Summary: | Apache Reloaded twice with logrotate | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Saif Ali <saali> | |
| Component: | Appliance | Assignee: | Joe Rafaniello <jrafanie> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | luke couzens <lcouzens> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 5.7.0 | CC: | abellott, jhardy, jrafanie, obarenbo, saali, smallamp | |
| Target Milestone: | MVP | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1569113 1569118 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-11 13:54:10 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1511957, 1555371, 1569113, 1569118 | |||
|
Description
Saif Ali
2017-07-01 14:36:46 UTC
Can we add /var/log/httpd/*log path to miq_logs.conf[1], and comment out the service reload in httpd [2].
[1]
~~~
/var/log/httpd/*log /var/www/miq/vmdb/log/*.log /var/www/miq/vmdb/log/apache/*.log /var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/*.log {
daily
dateext
missingok
rotate 14
notifempty
compress
copytruncate
prerotate
source /etc/default/evm; /bin/sh ${APPLIANCE_SOURCE_DIRECTORY}/logrotate_free_space_check.sh $1
endscript
lastaction
/sbin/service httpd reload > /dev/null 2>&1 || true
endscript
}
~~~
[2]
~~~
/var/log/httpd/*log {
missingok
notifempty
sharedscripts
delaycompress
postrotate
# /bin/systemctl reload httpd.service > /dev/null 2>/dev/null || true
endscript
}
~~~
If I wanted to test a different solution, what is the problem that I should recreate to see if the solution fixes it? I don't know why it was done this way but I also don't understand what the issue is. Joe, The problem apache get reloaded twice to do the same thing and we can avoid that by updating miq_logs.conf to include apache logs also. How do I test this? strace? Is there a problem this causes or just a waste of time reloading apache? Joe, To test this out run the below commands 1: watch the logs tail /var/www/miq/vmdb/log/apache/miq_apache.log -f 1: force httpd logrotate manually logrotate -f /etc/logrotate.d/httpd you should see apache get restarted 2: force miq logrotate manually logrotate -f /etc/logrotate.d/miq_logs.conf Its just waste of time reloading apache New commit detected on ManageIQ/manageiq-appliance/master: https://github.com/ManageIQ/manageiq-appliance/commit/21ad0757c828980dba66c8fc7e531520019b7e20 commit 21ad0757c828980dba66c8fc7e531520019b7e20 Author: Joe Rafaniello <jrafanie> AuthorDate: Mon Apr 16 14:44:14 2018 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Mon Apr 16 14:44:14 2018 -0400 httpd reload is not needed with copytruncate Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1467007 As far as I can tell, when this was added originally in: 66b7a339cf1fc6deef9277bcf685a298bb79d4e4 the httpd reload was copied from the /etc/logrotate.d/httpd script provided by the httpd package. The /etc/logrotate.d/httpd script does this because the log files are rotated and httpd needs to reopen the file descriptors for these logs. Interestingly, this is not required if you use the 'copytruncate' option, which gracefully copies, compresses, and truncates the logs without messing up any existing file descriptors. Therefore, since we originally added this httpd reload in addition to the 'copytruncate', we never needed the former. See also: https://bugzilla.redhat.com/show_bug.cgi?id=MANAGEIQ-13457 COPY/etc/logrotate.d/miq_logs.conf | 3 - 1 file changed, 3 deletions(-) Verified in 5.10 |