Bug 1467049

Summary:	Review Request: nuvola-app-deezer - Deezer for Nuvola Player 3
Product:	[Fedora] Fedora	Reporter:	MartinKG <mgansser>
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, vondruch
Target Milestone:	---	Flags:	vondruch: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/tiliado/nuvola-app-deezer
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-16 11:34:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MartinKG 2017-07-02 09:34:16 UTC

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-deezer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-deezer-2.6-1.fc25.src.rpm

Description: Integration of Deezer into your linux desktop via Nuvola Player.
Fedora Account System Username: martinkg

rpmlint -i -v nuvola-app-deezer.spec /home/martin/rpmbuild/SRPMS/nuvola-app-deezer-2.6-1.fc25.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-deezer-2.6-1.fc25.noarch.rpm
nuvola-app-deezer.spec: I: checking
nuvola-app-deezer.spec:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-deezer.spec: I: checking-url https://github.com/tiliado/nuvola-app-deezer/archive/2.6.tar.gz#/nuvola-app-deezer-2.6.tar.gz (timeout 10 seconds)
nuvola-app-deezer.src: I: checking
nuvola-app-deezer.src: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.

nuvola-app-deezer.src: I: checking-url https://github.com/tiliado/nuvola-app-deezer (timeout 10 seconds)
nuvola-app-deezer.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-deezer.src: I: checking-url https://github.com/tiliado/nuvola-app-deezer/archive/2.6.tar.gz#/nuvola-app-deezer-2.6.tar.gz (timeout 10 seconds)
nuvola-app-deezer.noarch: I: checking
nuvola-app-deezer.noarch: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.

nuvola-app-deezer.noarch: I: checking-url https://github.com/tiliado/nuvola-app-deezer (timeout 10 seconds)
nuvola-app-deezer.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppDeezer.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error

2 packages and 1 specfiles checked; 0 errors, 5 warnings.

%changelog
* Sun Jul 02 2017 Martin Gansser <martinkg> - 2.6-1
- Update to 2.6-1

* Sat Jan 21 2017 Martin Gansser <martinkg> - 2.5-1
- initial build

Comment 1 MartinKG 2017-07-27 15:27:03 UTC

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-deezer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-deezer-2.6-2.fc26.src.rpm

%changelog
* Thu Jul 27 2017 Martin Gansser <martinkg> - 2.6-2
- correct the extends/name-tag in %%{name}.metainfo.xml

Comment 2 MartinKG 2017-08-03 09:32:18 UTC

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-deezer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-deezer-2.7-1.fc26.src.rpm

%changelog
* Thu Aug 03 2017 Martin Gansser <martinkg> - 2.7-1
- Update to 2.7

Comment 3 Vít Ondruch 2017-08-04 11:36:10 UTC

I'm taking this for a review.

Comment 4 Vít Ondruch 2017-08-04 11:55:16 UTC

* Typo in .metainfo.xml
  - s/Intergration/Integration/
  - But it would be probably better to drop the suffix entirely, since I don't
    see any purpose in it.

Otherwise, the package looks good => APPROVE

Comment 5 MartinKG 2017-08-04 16:29:31 UTC

Thanks for the review.

%changelog
* Fri Aug 04 2017 Martin Gansser <martinkg> - 2.7-2
- correct %%{name}.metainfo.xml

Comment 6 Ralph Bean 2017-08-10 16:54:36 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-deezer

Comment 7 Ralph Bean 2017-08-10 16:54:48 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-deezer

Comment 8 MartinKG 2017-08-16 11:34:52 UTC

package has been built successfully on f25, f26 and rawhide.