Bug 1467253

Summary:	Review Request: perl-Image-Sane - Perl extension for the SANE (Scanner Access Now Easy) Project
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Image-Sane-0.12-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-04 06:55:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1467030

Description Petr Pisar 2017-07-03 09:04:16 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Image-Sane/perl-Image-Sane.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Image-Sane/perl-Image-Sane-0.12-1.fc27.src.rpm
Description:
These Perl bindings for the SANE (Scanner Access Now Easy) Project allow
you to access SANE-compatible scanners in a Perlish and object-oriented
way, freeing you from the casting and memory management in C, yet remaining
very close in spirit to original API.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-07-03 14:02:26 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Image-Sane-0.12-1.fc27.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.26()(64bit)
      1 libsane.so.1()(64bit)
      1 perl(base)
      1 perl(Exception::Class)
      1 perl(Exporter)
      1 perl(Image::Sane::Device)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Readonly)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.5
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Image-Sane-0.12-1.fc27.x86_64.rpm | sort | uniq -c
      1 perl(Image::Sane) = 0.12
      1 perl-Image-Sane = 0.12-1.fc27
      1 perl(Image::Sane::Device)
      1 perl-Image-Sane(x86-64) = 0.12-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Image-Sane*
perl-Image-Sane.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-Image-Sane.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-07-03 15:07:48 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Image-Sane

Comment 3 Petr Pisar 2017-07-04 06:55:23 UTC

Thank you for the review and the repository.