Bug 1467347

Summary: /usr/bin/python3 /usr/share/java-utils/pom_editor.py pom_remove_parent causes traceback in F24
Product: [Fedora] Fedora Reporter: Mattias Ellert <mattias.ellert>
Component: javapackages-toolsAssignee: Michael Simacek <msimacek>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: ctubbsii, java-sig-commits, mat.booth, mizdebsk, msimacek, msrb
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: javapackages-tools-4.6.0-16.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-12 01:51:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mattias Ellert 2017-07-03 13:14:19 UTC
Description of problem:

/usr/bin/python3 /usr/share/java-utils/pom_editor.py pom_remove_parent
Traceback (most recent call last):
  File "/usr/share/java-utils/pom_editor.py", line 640, in <module>
    macros[sys.argv[1]](*sys.argv[2:])
  File "/usr/share/java-utils/pom_editor.py", line 466, in decorated
    xml.patch(function, fnargs)
  File "/usr/share/java-utils/pom_editor.py", line 258, in patch
    function(**fnargs)
  File "/usr/share/java-utils/pom_editor.py", line 583, in pom_remove_parent
    etree.Comment(" parent POM reference removed by maintainer --> "))
  File "src/lxml/lxml.etree.pyx", line 3017, in lxml.etree.Comment (src/lxml/lxml.etree.c:77005)
ValueError: Comment may not contain '--' or end with '-'


Version-Release number of selected component (if applicable):

javapackages-tools.noarch 4.6.0-15.fc24

How reproducible:

Happens both in koji and in a local mock build

Steps to Reproduce:
1. Build jglobus-2.1.0-6.fc24.src.rpm

Actual results:

Traceback (see above)

Expected results:

Successful build

Additional info:

Only happens in F24.
EPEL7, F25, F26 and rawhide all work.

Failed build (F24):

https://koji.fedoraproject.org/koji/taskinfo?taskID=20305430

Same srpm build successfully on EPEL7, F25, F26 and rawhide:

https://koji.fedoraproject.org/koji/taskinfo?taskID=20305433
https://koji.fedoraproject.org/koji/taskinfo?taskID=20305428
https://koji.fedoraproject.org/koji/taskinfo?taskID=20305426
https://koji.fedoraproject.org/koji/taskinfo?taskID=20305425

Comment 1 Fedora Update System 2017-07-03 13:45:17 UTC
javapackages-tools-4.6.0-16.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab2e980e61

Comment 2 Michael Simacek 2017-07-03 13:56:34 UTC
I submitted a buildroot override with the fixed package:
https://bodhi.fedoraproject.org/overrides/javapackages-tools-4.6.0-16.fc24

Comment 3 Fedora Update System 2017-07-04 02:50:05 UTC
javapackages-tools-4.6.0-16.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab2e980e61

Comment 4 Fedora Update System 2017-07-12 01:51:41 UTC
javapackages-tools-4.6.0-16.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.