Bug 1467427
| Summary: | dracut hostonly misses modules that are built-in or renamed from the running kernel | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andy Lutomirski <luto> |
| Component: | dracut | Assignee: | dracut-maint-list |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 27 | CC: | dracut-maint-list, harald, jonathan, yaneti, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-30 17:39:00 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
https://github.com/dracutdevs/dracut Issue tracker and Pull requests seem attended (In reply to Andy Lutomirski from comment #0) > I'm filing this here because upstream doesn't appear to have a bug tracker. > This bug also bit me because I sometimes run home-built kernels on Fedora 25. > > Dracut does this: > > static bool check_module_hostonly(struct kmod_module *mod) > { > const char *name = kmod_module_get_name(mod); > > if (check_hashmap(modules_loaded, name)) > return true; > > return false; > } > > This is prone to false negatives. A much better approach would be to also > accept the module if its modalias matches anything on the running system. > Basically, dracut should do the equivalent of: > > find /sys -name modalias |xargs cat > > and then check if any of the modalias lines in `modinfo $module` match any > of the modaliases on the system. > > The specific failure I'm seeing is that I ran a kernel that had nvme built > in and then allowed dnf to install a new kernel. The new kernel's initramfs > was missing nvme-core and nvme. I suspect this could bite non kernel devs > who upgrade to a kernel that renames a module, though. Yeah, you are right with your analysis. Will try to implement your suggestion. might be fixed with: https://github.com/dracutdevs/dracut/commit/3ad12c7be89b79bee43b0871a8d2cac826b7d625 This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'. This message is a reminder that Fedora 27 is nearing its end of life. On 2018-Nov-30 Fedora will stop maintaining and issuing updates for Fedora 27. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '27'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 27 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 27 changed to end-of-life (EOL) status on 2018-11-30. Fedora 27 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |
I'm filing this here because upstream doesn't appear to have a bug tracker. This bug also bit me because I sometimes run home-built kernels on Fedora 25. Dracut does this: static bool check_module_hostonly(struct kmod_module *mod) { const char *name = kmod_module_get_name(mod); if (check_hashmap(modules_loaded, name)) return true; return false; } This is prone to false negatives. A much better approach would be to also accept the module if its modalias matches anything on the running system. Basically, dracut should do the equivalent of: find /sys -name modalias |xargs cat and then check if any of the modalias lines in `modinfo $module` match any of the modaliases on the system. The specific failure I'm seeing is that I ran a kernel that had nvme built in and then allowed dnf to install a new kernel. The new kernel's initramfs was missing nvme-core and nvme. I suspect this could bite non kernel devs who upgrade to a kernel that renames a module, though.