Bug 1467566

Summary:	[RFE] make engine-upgrade-check to warn about not having latest version of current minor branch
Product:	[oVirt] ovirt-engine	Reporter:	Jiri Belka <jbelka>
Component:	Setup.Engine	Assignee:	Sandro Bonazzola <sbonazzo>
Status:	CLOSED WONTFIX	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.1.2	CC:	bugs, danken, dougsland, jbelka, ylavi
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---	Flags:	ylavi: ovirt-future? rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-12 11:13:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jiri Belka 2017-07-04 08:40:30 UTC

Description of problem:

Does engine-upgrade-check verify we have latest version of current engine minor branch before updating to newer version, ie. 4.0 -> 4.1?

This is what we usually say to clients to have.

engine-upgrade-check needs both repos for current version and for next version, ie. 4.0 and 4.1 repos.

I suppose usually update check would show only latest versions, ie. 4.1, but we would need to know also latest from current, ie 4.0.

At least 'yum list all --showduplicates' shows all versions of packages, thus one could compare installed version of 4.0 with latest 4.0 in repo and also to know 4.1 to upgrade to.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. have not latest 4.0
2. engine-upgrade-check
3. see if there is info for not having latest 4.0 before upgrading to 4.1

Actual results:
no such info exists

Expected results:
could help users in upgrades as in latest versions could be fixes to make upgrade succeed

Additional info:
info should be just a kind of warning, to highlight the info to users that we do recommend having latest version before upgrade

Comment 1 Sandro Bonazzola 2017-07-21 07:41:30 UTC

I'm not sure to understand the request.
If you have ovirt-release40.rpm installed (or RHV 4.0 channel enabled) and you're running ovrt 4.0.1, when you execute engine-upgrade-check it warns you about new 4.0.z minor update available.

When you install ovirt-release41.rpm (or enable RHV 4.1 channel) it warns you about a 4.1 update available.

Running engine-setup will update to the version detected by engine-upgrade-check so the behavior is consistent.

Our documentation says first to upgrade to latest minor and then upgrade to next version. So above behavior seems correct and consistent with our documentation and tooling.
CCing Dan and Douglas.

Comment 2 Jiri Belka 2017-07-26 10:22:12 UTC

(In reply to Sandro Bonazzola from comment #1)
> [...]
> When you install ovirt-release41.rpm (or enable RHV 4.1 channel) it warns
> you about a 4.1 update available.

That's ok but it does not produce warning I am not on latest minor of 4.0 for example.

> Running engine-setup will update to the version detected by
> engine-upgrade-check so the behavior is consistent.
> 
> Our documentation says first to upgrade to latest minor and then upgrade to
> next version. So above behavior seems correct and consistent with our
> documentation and tooling.

So you want to say one has to run twice the script, one before adding for example 4.1 repos, and once after 4.1 repos were added?

Comment 3 Sandro Bonazzola 2017-08-02 12:25:45 UTC

(In reply to Jiri Belka from comment #2)

> So you want to say one has to run twice the script, one before adding for
> example 4.1 repos, and once after 4.1 repos were added?

Yes

Comment 4 Yaniv Lavi 2018-06-12 11:13:15 UTC

Closing old RFEs, please reopen if still needed.
Patches are always welcome.