Bug 146757
| Summary: | local variable used before set | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> |
| Component: | gtkhtml3 | Assignee: | Dave Malcolm <dmalcolm> |
| Status: | CLOSED RAWHIDE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-08-18 20:10:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 150221 | ||
Thanks for this report. I agree that this code is bizarre, and will work on getting it fixed upstream. It's been fixed in upstream CVS: http://cvs.gnome.org/viewcvs/gtkhtml/src/htmltextslave.c?r1=1.188.2.3&r2=1.188.2.4 Bug was fixed by gtkhtml-3.7.5, so fixed it's fixed in rawhide. Bug exists from gtkhtml-3.5.3 to gtkhtml-3.6.2, so potentially affects FC4, but does not affect FC3. |
Description of problem: I just tried to compile package gtkhtml3-3.5.4-1 from Redhat Fedora development tree. The compiler said htmltextslave.c(184): remark #592: variable "gi" is used before its value is set The source code is HTMLTextSlaveGlyphItem *gi = (HTMLTextSlaveGlyphItem *) gi; if (gi->type == HTML_TEXT_SLAVE_GLYPH_ITEM_CREATED) { Bizzare code. gi gets initialised with it's own (undefined) value, and then it gets used as a valid pointer in the if statement. Suggest code re-work. Has this code ever been tested ? Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: