Bug 1467804

Summary: Issuing multiple concurrent LSM with different disks fails
Product: [oVirt] ovirt-engine Reporter: Benny Zlotnik <bzlotnik>
Component: BLL.StorageAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED CURRENTRELEASE QA Contact: Lilach Zitnitski <lzitnits>
Severity: high Docs Contact:
Priority: unspecified    
Version: futureCC: bugs, tnisan
Target Milestone: ovirt-4.2.0Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:10:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
A script to reproduce none

Description Benny Zlotnik 2017-07-05 08:14:19 UTC 
Created attachment 1294489 [details]
A script to reproduce

Description of problem:
Issuing multiple concurrent LSM with different disks will fail when attempting to remove one of the auto-generated snapshots. It will not be possible to remove the remaining snapshots manually as well after this, as the snapshot was not created properly.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM
2. Add 2 disks to the VM and run the VM
3. Issue to move commands using the REST API, an example script is attached

Actual results:
One of the disk will move and have its auto-generated snapshot removed correctly,
The other will move but the removal of its auto-generated snapshot will fail.

Expected results:
Both should succeed

Additional info:
This is not the same issue as https://bugzilla.redhat.com/1460694 in which we move the same disk twice.

This bug is caused by a race condition in the validation stage of the creation of the snapshot.
Comment 1 Benny Zlotnik 2017-10-16 08:59:02 UTC 
The attached patches fix this bug as a side effect, moving to MODIFIED
Comment 2 Lilach Zitnitski 2017-10-25 08:33:53 UTC 
--------------------------------------
Tested with the following code:
----------------------------------------
ovirt-engine-4.2.0-0.0.master.20171022103432.gitaf9d8b6.el7.centos.noarch
vdsm-4.20.3-216.git87725ec.el7.centos.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. Create a VM
2. Add 2 disks to the VM and run the VM
3. Issue to move commands using the REST API

Actual results:
Both disks moved successfully to the new storage domain and the auto-generated snapshots were deleted at the end of the process. 

Expected results:

Moving to VERIFIED!
Comment 3 Sandro Bonazzola 2017-12-20 11:10:35 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.