Bug 1467809

Summary: overlay docker storage driver should be supported for old operation systems in health check
Product: OpenShift Container Platform Reporter: Gan Huang <ghuang>
Component: InstallerAssignee: Rodolfo Carvalho <rcarvalh>
Status: CLOSED CURRENTRELEASE QA Contact: Gan Huang <ghuang>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.0CC: aos-bugs, ghuang, jokerman, lmeyer, mmccomas, sdodson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1469197 (view as bug list) Environment:
Last Closed: 2017-07-17 14:00:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1469197    

Description Gan Huang 2017-07-05 08:27:07 UTC
Description of problem:
Trigger a installation on RHEL7.2/RHEL7.3 with overlay driver enabled, it failed at openshift_health_check:
       
 "docker_storage": {
            "changed": true, 
            "failed": true, 
            "msg": "Detected unsupported Docker storage driver 'overlay'.\nSupported storage drivers are: devicemapper, overlay2"

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.133-1.git.0.950bb48.el7.noarch.rpm

How reproducible:
always

Steps to Reproduce:
1. Provision RHEL 7.2/7.3 to be installed, and enabled overlay docker storage driver.
2. Trigger 3.6 installation
#cat inventory_hosts
<--snip-->
openshift_docker_selinux_enabled=false
<--snip-->

Actual results:
Installation failed at health check:
 "docker_storage": {
            "changed": true, 
            "failed": true, 
            "msg": "Detected unsupported Docker storage driver 'overlay'.\nSupported storage drivers are: devicemapper, overlay2"


Expected results:
For old operation system, we should be able to tolerate overlay docker storage by detecting kernel version.


Additional info:

Comment 2 Luke Meyer 2017-07-05 13:15:46 UTC
I don't believe overlay has ever been a driver we support for Docker, nor that it ever will be (given support coming for overlay2). I thought it was only tech preview. Do you know otherwise? Customers may be using it but that doesn't mean we support it.

Comment 5 Luke Meyer 2017-07-06 13:35:35 UTC
This is a legitimate bug, overlay and overlay2 drivers are considered supported for the Docker use case since RHEL 7.3.(4? 5?) under limited conditions. With 7.4 they will actually work under --selinux-enabled too, but before that should have it disabled. Need to figure out corresponding kernel versions and consider what to say for non-RHEL/CentOS.

Comment 6 Rodolfo Carvalho 2017-07-10 15:50:26 UTC
Adding overlay to the list of supported drivers in https://github.com/openshift/openshift-ansible/pull/4722

Later on we may refine the check to verify other conditions as Luke mentions.

Comment 7 Luke Meyer 2017-07-12 13:01:47 UTC
PR merged to master. This is just the simplest fix that allows you to use "overlay" without really checking anything else if you are.

Comment 8 Rodolfo Carvalho 2017-07-14 14:24:39 UTC
Gan Huang, could you re-test please?

Comment 9 Gan Huang 2017-07-17 06:59:10 UTC
Verified in openshift-ansible-3.6.151-1.git.0.a82f0c2.el7.noarch.rpm

Comment 10 Luke Meyer 2017-07-17 14:00:15 UTC
Closing as never released.