Bug 1467999

Summary: After deploying containerized OSP12 with opstools templates ,sensu-client and collectd containers were created only on controller. Should be created on all overcloud nodes.
Product: Red Hat OpenStack Reporter: Leonid Natapov <lnatapov>
Component: openstack-tripleo-heat-templatesAssignee: Emilien Macchi <emacchi>
Status: CLOSED ERRATA QA Contact: Leonid Natapov <lnatapov>
Severity: high Docs Contact:
Priority: high    
Version: 12.0 (Pike)CC: amuller, lnatapov, m.andre, mburns, rhallise, rhel-osp-director-maint, scorcora, tvignaud
Target Milestone: betaKeywords: Triaged
Target Release: 12.0 (Pike)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-7.0.0-0.20170718190543.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-13 21:39:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Leonid Natapov 2017-07-05 18:33:17 UTC
Description of problem:

After deploying containerized OSP12 with opstools templates ,sensu-client and collectd containers were created only on controller. Should be created on all overcloud nodes.

Deploy command I used:

openstack overcloud deploy --templates --libvirt-type kvm --ntp-server clock.redhat.com --control-scale 1 --control-flavor controller --compute-scale 1 --compute-flavor compute -e /home/stack/virt/network/network-environment.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml  -e /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/services-docker/sensu-client.yaml -e monitoring.yaml  -e  /usr/share/openstack-tripleo-heat-templates/environments/services-docker/collectd.yaml -e local_config.yaml -e docker-osp12.yaml


Only on controller I see:
-------------------------

d399ac65bf6d        192.168.24.1:8787/rhosp12/openstack-sensu-client-docker:2017-07-02.2                "kolla_start"            8 hours ago         Up 8 hours                              sensu_client

9b5f3e7c546f        192.168.24.1:8787/rhosp12/openstack-collectd-docker:2017-07-02.2                    "kolla_start"            8 hours ago         Up 8 hours


Those containers should be created on all overcloud nodes.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Dan Prince 2017-07-07 14:19:18 UTC
Would like a bit more information here.

The SensuClient should be included in all roles by default now:

http://git.openstack.org/cgit/openstack/tripleo-heat-templates/tree/roles_data.yaml

----

This could be caused by an environmental custom heat parameter that overrides the list of services for the compute role. Is ComputeServicesDefault getting set anywhere in the custom environment variables?

Comment 2 Omri Hochman 2017-07-07 15:26:03 UTC
Leonid -  can you please check the configuration files, even better if you can attach them to the Bz for dprince review.  
Thanks,

Comment 3 Leonid Natapov 2017-07-07 18:25:52 UTC
(In reply to Omri Hochman from comment #2)
> Leonid -  can you please check the configuration files, even better if you
> can attach them to the Bz for dprince review.  
> Thanks,

Sure,Omri. What files exactly do you want me to attach ?

sensu,fluentd and colletcd included in all roles by default,that's true.
I checked the role files of Controller,Compute and others.

Comment 5 Dan Prince 2017-07-07 19:59:05 UTC
I took a look at the environment and this is what I saw getting configured in this environment: 

(undercloud) [stack@undercloud-0 ~]$ openstack stack show overcloud | grep ComputeServices
|                       | ComputeServices: OS::TripleO::Services::NovaCompute,OS::TripleO::Services::NovaLibvirt,OS::TripleO::Services::ComputeNeutronOvsAgent,OS::TripleO::Services::Docker,OS::TripleO::Services::CeilometerAgentCompute,OS::TripleO::Services::Sshd   

----

This matches what is hard coded in the environments/docker.yaml upstream which would explain why you don't see SensuClient in this list... because it isn't there.

It looks like we need to reconcile this upstream and get the ComputeServices correctly represented a single location (probably role_data.yaml).

In short this is a valid bug.

Comment 6 Dan Prince 2017-07-07 20:09:54 UTC
We'll need to sort this out upstream:

https://review.openstack.org/481747 Drop ComputeServices from environments/docker.yaml

If you want to try cherry-picking the fix downstream it should be safe to do so. Alternately you could explicitly specify your a custom ComputeServices heat parameter that matches the setting in roles_data.yaml to get the same effect. Either of these solutions would be a valid work around to this issue for now.

Comment 7 Martin André 2017-07-17 14:25:31 UTC
Moving to POST since the upstream fix was merged.

Comment 9 Leonid Natapov 2017-08-02 12:33:22 UTC
openstack-tripleo-heat-templates-7.0.0-0.20170721174554.el7ost.noarch

[root@overcloud-compute-0 heat-admin]# docker ps
CONTAINER ID        IMAGE                                                                   COMMAND             CREATED             STATUS              PORTS               NAMES
315dcdb63921        192.168.24.1:8787/rhosp12/openstack-nova-compute-docker:2017-07-26.10   "kolla_start"       26 minutes ago      Up 26 minutes                           nova_compute
f73e2070137b        192.168.24.1:8787/rhosp12/openstack-iscsid-docker:2017-07-26.10         "kolla_start"       30 minutes ago      Up 30 minutes                           iscsid
04e8e89c5bf5        192.168.24.1:8787/rhosp12/openstack-nova-libvirt-docker:2017-07-26.10   "kolla_start"       30 minutes ago      Up 30 minutes                           nova_libvirt
0a697fd352af        192.168.24.1:8787/rhosp12/openstack-collectd-docker:2017-07-26.10       "kolla_start"       30 minutes ago      Up 30 minutes                           collectd
ed3299b671b3        192.168.24.1:8787/rhosp12/openstack-sensu-client-docker:2017-07-26.10   "kolla_start"       30 minutes ago      Up 30 minutes                           sensu_client
[root@overcloud-compute-0 heat-admin]#

Comment 13 errata-xmlrpc 2017-12-13 21:39:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462