Bug 1468124

Summary:	Change the default value of Enable Discard to true
Product:	[oVirt] ovirt-engine	Reporter:	Idan Shaby <ishaby>
Component:	Backend.Core	Assignee:	Nobody <nobody>
Status:	CLOSED DEFERRED	QA Contact:	Avihai <aefrat>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.2.0	CC:	bugs, ebenahar, nsoffer, tnisan
Target Milestone:	---	Keywords:	Improvement, Reopened
Target Release:	---	Flags:	ylavi: ovirt-4.3+ ratamir: testing_plan_complete-
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-01 14:44:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Idan Shaby 2017-07-06 06:32:01 UTC

Description of problem:
Today, the default value of Enable Discard is false, thus making it less accessible to users.
Since today users use storage arrays that support discard by default, it would be better if Enable Discard was true by default, on both file and block storage.

Version-Release number of selected component (if applicable):
93050ca386c3424af6c18135eeeec9caaee2b711

How reproducible:
100%

Steps to Reproduce:
1. Add a new disk image on file/block domain, or add a new direct lun.

Actual results:
Enable Discard is false by default.

Expected results:
Should be true.

Comment 2 Yaniv Lavi 2017-11-06 09:30:57 UTC

Is this already done?

Comment 3 Raz Tamir 2017-11-06 09:35:11 UTC

Is this bug is a dup of https://bugzilla.redhat.com/show_bug.cgi?id=1456414 ?

Comment 4 Idan Shaby 2017-11-06 09:40:07 UTC

Yaniv - no, not yet.
Raz - no, Discard After Delete and Enable Discard are two different fields.

Comment 5 Yaniv Kaul 2017-11-26 07:30:25 UTC

Is this on track to 4.2.0?

Comment 6 Idan Shaby 2017-11-26 10:04:33 UTC

Probably not, I will check what we can do about it and retarget if needed.

Comment 9 Tal Nisan 2018-05-16 10:21:26 UTC

Idan, any progress on the issue?

Comment 10 Idan Shaby 2018-05-17 06:23:48 UTC

Not yet, it's targeted to 4.4, and it may be possible to make it for 4.3. I'll update here when I have more information.

Comment 14 Sandro Bonazzola 2019-01-28 09:34:04 UTC

This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 15 Michal Skrivanek 2020-03-18 15:43:35 UTC

This bug didn't get any attention for a while, we didn't have the capacity to make any progress. If you deeply care about it or want to work on it please assign/target accordingly

Comment 16 Michal Skrivanek 2020-03-18 15:46:49 UTC

This bug didn't get any attention for a while, we didn't have the capacity to make any progress. If you deeply care about it or want to work on it please assign/target accordingly

Comment 17 Michal Skrivanek 2020-04-01 14:44:28 UTC

ok, closing. Please reopen if still relevant/you want to work on it.

Comment 18 Michal Skrivanek 2020-04-01 14:49:28 UTC

ok, closing. Please reopen if still relevant/you want to work on it.