Bug 1469210

Summary:	NRPE behavior changed, include_dir no longer overrides commands defined in /etc/nagios/nrpe.cfg
Product:	[Fedora] Fedora EPEL	Reporter:	Chris Herdt <cherdt>
Component:	nrpe	Assignee:	Stephen John Smoogen <smooge>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	epel7	CC:	athmanem, b.heden, bugzilla, jose.p.oliveira.oss, kmf, ondrejj, smooge, smooge, s, swilkerson
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	nrpe-3.1.1-6.fc24 nrpe-3.1.1-6.fc25 nrpe-3.2.0-6.el7 nrpe-3.2.0-6.el6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-16 15:47:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Herdt 2017-07-10 16:19:03 UTC

Description of problem:
There are 5 NRPE command definitions hard-coded in the default
/etc/nagios/nrpe.cfg file:
- check_users
- check_load
- check_hda1
- check_zombie_procs
- check_total_procs

Previously, definitions in files in the defined include_dir (e.g. include_dir=/etc/nrpe.d) would override these definitions. Now definitions in the include_dir do not override the default definitions.

Version-Release number of selected component (if applicable):
nrpe.x86_64 3.1.1-1.el7

How reproducible:
Always

Steps to Reproduce:
1. Turn on debugging in /etc/nagios/nrpe.cfg: debug=1
2. Add debug messages (*.debug) to rsyslog config for /var/log/messages, i.e.
/etc/rsyslog.conf
3. Create a file in /etc/nrpe.d, e.g. /etc/nrpe.d/load.cfg, containing custom
values for a check_load command: command[check_load]=/usr/lib64/nagios/plugins/check_load -w 6.4,6.2,6.0 -c 7.9,7.5,7.0
4. Restart NRPE, trigger the check_load command.
5. Confirm in /var/log/messages that the check_load command parameters from
/etc/nagios/nrpe.cfg are used instead of the parameters from
/etc/nrpe.d/load.cfg

Actual results:
Definition from /etc/nagios/nrpe.cfg is used

Expected results:
Definition from include_dir is used

Additional info:
If the include_dir directive is moved to the bottom of /etc/nagios/nrpe.cfg,
definitions in the include_dir do override the default definitions. This seems
to be a precedence issue. The new behavior makes sense, but the placement of the
include_dir directive no longer makes sense given the new behavior.

Users can modify /etc/nagios/nrpe.cfg, but it would be preferable to
keep host-based changes in /etc/nrpe.d so that they are preserved with future package updates.
change my per host values.

Comment 1 Stephen John Smoogen 2017-07-10 16:53:30 UTC

Please look at the version in updates-testing and give it positive karma in bodhi if it fixes the problem.

https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f8ea02db72



https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-86db243830

Comment 2 Fedora Update System 2017-07-12 15:53:06 UTC

nrpe-3.1.1-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9d9d9c0909

Comment 3 Fedora Update System 2017-07-12 16:24:49 UTC

nrpe-3.1.1-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ec253d8f54

Comment 4 Fedora Update System 2017-07-13 01:46:10 UTC

nrpe-3.1.1-6.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-18adf0fe26

Comment 5 Fedora Update System 2017-07-13 01:50:22 UTC

nrpe-3.1.1-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1f50be4847

Comment 6 Fedora Update System 2017-07-23 21:50:51 UTC

nrpe-3.1.1-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2017-07-23 22:54:19 UTC

nrpe-3.1.1-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2017-08-04 20:18:50 UTC

nrpe-3.2.0-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-030b96c51c

Comment 9 Fedora Update System 2017-08-07 02:49:34 UTC

nrpe-3.2.0-6.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-bb989d629b

Comment 10 Fedora Update System 2017-08-07 07:49:32 UTC

nrpe-3.2.0-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-030b96c51c

Comment 11 Fedora Update System 2017-11-16 15:47:54 UTC

nrpe-3.2.0-6.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2017-11-16 16:53:02 UTC

nrpe-3.2.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.