Bug 1469470

Summary: Company Specific Messages table on the login page should gracefully handle large amounts of text.
Product: Red Hat Satellite Reporter: Nikhil Kathole <nkathole>
Component: SettingsAssignee: Tomas Strachota <tstrachota>
Status: CLOSED ERRATA QA Contact: Nikhil Kathole <nkathole>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.3.0CC: bbuckingham, cwelton, dlobatog, ehelms, jcallaha, sghai, walden
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/21200
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-21 17:06:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot of UI
none
Screenshot of login page none

Description Nikhil Kathole 2017-07-11 10:32:02 UTC
Created attachment 1296175 [details]
screenshot of UI

Description of problem: The Company Specific Messages on the login page can cover all login page and the user interface under settings-> general tab breaks.Thus, there should be character limit.


Version-Release number of selected component (if applicable): sat 6.3 snap 6.0


How reproducible: always


Steps to Reproduce:
1. Navigate to Administer -> settings
2. Click on general tab 
3. Enter large Login page footer message

Actual results:
Login page and UI under settings-> general breaks.

Expected results:
There should be constraint to character limit so that login page UI and  settings-> general tab page should not break.

Additional info:

Comment 3 Daniel Lobato Garcia 2017-08-09 09:55:07 UTC
I don't think there should be a limit. Instead, the settings should be able to resize the table accordingly to the content. In fact some of the requesters of the RFE https://bugzilla.redhat.com/show_bug.cgi?id=726570 ask for pretty large texts to be included.

Comment 4 Corey Welton 2017-08-11 18:32:37 UTC
Agree, to some degree, with comment #3.  The proper way would be to assure table can gracefully handle a bunch of text.

There probably should be some sort of validation, however, that someone can't DDoS or otherwise make a login screen unusable due to malicious (or inadvertent) inclusion of excessive content.

Comment 5 Walden Raines 2017-10-04 20:36:49 UTC
Created redmine issue http://projects.theforeman.org/issues/21200 from this bug

Comment 6 Satellite Program 2017-10-10 15:12:46 UTC
Upstream bug assigned to tstrachota

Comment 7 Walden Raines 2017-10-17 14:17:47 UTC
PR:  https://github.com/theforeman/foreman/pull/4915

Comment 8 Satellite Program 2017-10-23 14:13:33 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/21200 has been resolved.

Comment 9 Nikhil Kathole 2017-10-30 10:52:27 UTC
VERIFIED

Version Tested:
Satellite-6.3 Snap 22

steps:

1. Inserted large text in Login page footer message parameter under settings

Login page handled the larger data.

Comment 10 Nikhil Kathole 2017-10-30 10:54:19 UTC
Created attachment 1345372 [details]
Screenshot of login page

Comment 11 Bryan Kearney 2018-02-21 17:06:59 UTC
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.

For information on the advisory, and where to find the updated files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0336