Bug 1470489
| Summary: | bulk removexattr shouldn't allow removal of trusted.gfid/trusted.glusterfs.volume-id | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Pranith Kumar K <pkarampu> |
| Component: | posix | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.12.0 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-05 17:36:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
REVIEW: https://review.gluster.org/17765 (storage/posix: Don't allow gfid/volume-id xattr to be removed) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu) REVIEW: https://review.gluster.org/17765 (storage/posix: Don't allow gfid/volume-id xattr to be removed) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu) REVIEW: https://review.gluster.org/17765 (storage/posix: Don't allow gfid/volume-id xattr to be removed) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu) REVIEW: https://review.gluster.org/17765 (storage/posix: Don't allow gfid/volume-id xattr to be removed) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu) COMMIT: https://review.gluster.org/17765 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit 11eb8ba870457337c6067284dde4277e09764c0a Author: Pranith Kumar K <pkarampu> Date: Wed Jul 12 09:18:02 2017 +0530 storage/posix: Don't allow gfid/volume-id xattr to be removed Problem: Bulk xattr removal doesn't check if the xattrs that are coming in xdata have gfid/volume-id xattrs, so there is potential for bulkremovexattr removing gfid/volume-id. I also observed that bulkremovexattr is not available for fremovexattr. Fix: Do proper checks in bulk removexattr to remove gfid/volume-id. Refactor [f]removexattr to reduce the differences. BUG: 1470489 Change-Id: Ia845b31846a149500111c0996646e648f72cdce6 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: https://review.gluster.org/17765 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Anuradha Talur <atalur> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Krutika Dhananjay <kdhananj> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report. glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html [2] https://www.gluster.org/pipermail/gluster-users/ |
Description of problem: Problem: Bulk xattr removal doesn't check if the xattrs that are coming in xdata have gfid/volume-id xattrs, so there is potential for bulkremovexattr removing gfid/volume-id. I also observed that bulkremovexattr is not available for fremovexattr. Fix: Do proper checks in bulk removexattr to remove gfid/volume-id. Refactor [f]removexattr to reduce the differences. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: