Bug 1470656

Summary:	Review Request: perl-Regexp-Stringify - Stringify a Regexp object
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Regexp-Stringify-0.06-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-31 15:21:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1470678

Description Jitka Plesnikova 2017-07-13 12:10:20 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Regexp-Stringify/perl-Regexp-Stringify.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Regexp-Stringify/perl-Regexp-Stringify-0.06-1.fc27.src.rpm

Description:
This module is an alternative to Perl's default stringification of Regexp
object and has some features/options, e.g. producing regexp string that is
compatible with certain perl versions.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2017-07-24 11:00:03 UTC

URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 7a82fe44a2658d7ccc57f51a69954719473f066bf9148396b9f49b86593b56f5) is original. Ok.
Summary verified from lib/Regexp/Stringify.pm. Ok.
Description verified from lib/Regexp/Stringify.pm. Ok.
License verified from LICENSE and lib/Regexp/Stringify.pm. Ok.
No XS code, noarch BuildArch is Ok.
Test::Pod::Coverage and Pod::Coverage::TrustPod and Test::Pod are not used. Ok.

FIX: Build-require `perl(blib)' for tests (t/00-compile.t:19).

All tests pass. Ok.

$ rpmlint perl-Regexp-Stringify.spec ../SRPMS/perl-Regexp-Stringify-0.06-1.fc27.src.rpm ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm 
perl-Regexp-Stringify.src: W: spelling-error %description -l en_US stringification -> stratification, transmogrification, gentrification
perl-Regexp-Stringify.noarch: W: spelling-error %description -l en_US stringification -> stratification, transmogrification, gentrification
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 24 12:53 /usr/share/doc/perl-Regexp-Stringify
-rw-r--r--    1 root    root                      711 Oct 29  2016 /usr/share/doc/perl-Regexp-Stringify/Changes
-rw-r--r--    1 root    root                      431 Oct 29  2016 /usr/share/doc/perl-Regexp-Stringify/README
drwxr-xr-x    2 root    root                        0 Jul 24 12:53 /usr/share/licenses/perl-Regexp-Stringify
-rw-r--r--    1 root    root                    18367 Oct 29  2016 /usr/share/licenses/perl-Regexp-Stringify/LICENSE
-rw-r--r--    1 root    root                     2390 Jul 24 12:53 /usr/share/man/man3/Regexp::Stringify.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 24 12:53 /usr/share/perl5/vendor_perl/Regexp
-rw-r--r--    1 root    root                     5221 Oct 29  2016 /usr/share/perl5/vendor_perl/Regexp/Stringify.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Exporter)
      1 perl(re)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Regexp::Stringify) = 0.06
      1 perl-Regexp-Stringify = 0.06-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20711448). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-07-31 12:20:08 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Regexp-Stringify

Comment 3 Jitka Plesnikova 2017-07-31 15:21:52 UTC

Thank you for the review and the repository.