Bug 1470678

Summary:	Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Data-Dmp-0.23-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 13:04:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1470656
Bug Blocks:	1470705

Description Jitka Plesnikova 2017-07-13 12:51:49 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Data-Dmp/perl-Data-Dmp.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Data-Dmp/perl-Data-Dmp-0.23-1.fc27.src.rpm

Description:
This module is a Perl dumper like Data::Dumper. It's compact , starts fast
and does not use any non-core modules except Regexp::Stringify when dumping
regexes. It produces compact single-line output (similar to
Data::Dumper::Concise). It supports dumping objects, regexes, circular
structures, coderefs.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2017-08-01 06:27:39 UTC

URL and Source0 addresses are Ok.
Source0 archive (SHA-256: f2b326d703fb845d9dffd3b8b46d6c5d461143ac8f0f3c94d555ed294f0daf21) is original. Ok.
Summary verified from lib/Data/Dmp.pm. Ok.

TODO: Remove the space in `compact , starts' in the description.

License verified from lib/Data/Dmp.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl(blib)' for tests (t/00-compile.t:19).

Test::Pod, Test::Pod::Coverage, and Pod::Coverage::TrustPod are not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Data-Dmp.spec ../SRPMS/perl-Data-Dmp-0.23-1.fc27.src.rpm ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm 
perl-Data-Dmp.src: W: spelling-error %description -l en_US Stringify -> Stringy
perl-Data-Dmp.src: W: spelling-error %description -l en_US regexes -> regexps, regex's, reg exes
perl-Data-Dmp.src: W: spelling-error %description -l en_US coderefs -> code refs, code-refs, recorders
perl-Data-Dmp.noarch: W: spelling-error %description -l en_US Stringify -> Stringy
perl-Data-Dmp.noarch: W: spelling-error %description -l en_US regexes -> regexps, regex's, reg exes
perl-Data-Dmp.noarch: W: spelling-error %description -l en_US coderefs -> code refs, code-refs, recorders
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm
drwxr-xr-x    2 root    root                        0 Aug  1 08:20 /usr/share/doc/perl-Data-Dmp
-rw-r--r--    1 root    root                     2742 Jan 30  2017 /usr/share/doc/perl-Data-Dmp/Changes
-rw-r--r--    1 root    root                     5076 Jan 30  2017 /usr/share/doc/perl-Data-Dmp/README
drwxr-xr-x    2 root    root                        0 Aug  1 08:20 /usr/share/doc/perl-Data-Dmp/devscripts
-rw-r--r--    1 root    root                     1127 Aug  1 08:20 /usr/share/doc/perl-Data-Dmp/devscripts/bench
drwxr-xr-x    2 root    root                        0 Aug  1 08:20 /usr/share/licenses/perl-Data-Dmp
-rw-r--r--    1 root    root                    18367 Jan 30  2017 /usr/share/licenses/perl-Data-Dmp/LICENSE
-rw-r--r--    1 root    root                     4287 Aug  1 08:20 /usr/share/man/man3/Data::Dmp.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug  1 08:20 /usr/share/perl5/vendor_perl/Data
-rw-r--r--    1 root    root                    11944 Jan 30  2017 /usr/share/perl5/vendor_perl/Data/Dmp.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(B::Deparse)
      1 perl(Exporter)
      1 perl(Regexp::Stringify)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Data::Dmp) = 0.23
      1 perl-Data-Dmp = 0.23-1.fc27
Binary provides are Ok.

$ resolvedeps f27-build ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20938874). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item and consider fixing the `TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-08-01 12:25:03 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Data-Dmp

Comment 3 Jitka Plesnikova 2017-08-01 13:04:52 UTC

Thank you for the review and the repository.