Bug 1470851

Summary: Image Pull Error is being marked as Success
Product: OpenShift Container Platform Reporter: Shawn Hurley <shurley>
Component: Service BrokerAssignee: Jesus M. Rodriguez <jesusr>
Status: CLOSED DUPLICATE QA Contact: Zhang Cheng <chezhang>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.7.0CC: aos-bugs, jmatthew, tsanders
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-03 13:33:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Shawn Hurley 2017-07-13 20:03:18 UTC
Description of problem:
When the broker is unable to pull the image from a registry it will incorrectly set the state to succeded.

Version-Release number of selected component (if applicable):


How reproducible:
Always 

Steps to Reproduce:
1. Setup a service so that the APB can not be pulled from the registry and the broker always pulls.
2. Provision the service
3.

Actual results:
See that the service succeeded in the etcd job status like this:
{"action":"get","node":{"key":"/state/d6ad07d5-51b3-437b-afe8-870eb4ce5482/job","dir":true,"nodes":[{"key":"/state/d6ad07d5-51b3-437b-afe8-870eb4ce5482/job/4924d165-56fa-4236-b52d-506ded36572e","value":"{\"token\":\"4924d165-56fa-4236-b52d-506ded36572e\",\"state\":\"succeeded\",\"podname\":\"apb-f36b9efb-4c82-4c4f-9880-4eab6ffa5fb4\"}","modifiedIndex":9,"createdIndex":9}],"modifiedIndex":7,"createdIndex":7}}

You should also see the create console screen say that the service was provisioned correctly.

Expected results:
The job should be marked as a failure or in progress if additional attempts at pull are going to be made.

Additional info:

Comment 1 Jesus M. Rodriguez 2017-10-23 16:15:28 UTC
This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1504927

Comment 2 Jesus M. Rodriguez 2017-11-02 21:44:44 UTC
Fixed by PR 534: https://github.com/openshift/ansible-service-broker/pull/534

Comment 3 Jesus M. Rodriguez 2017-11-03 13:33:34 UTC

*** This bug has been marked as a duplicate of bug 1504927 ***