|Summary:||deadlock between multi-host recipe sets with host requirements can sometimes occur if jobs are dirty|
|Product:||[Community] Beaker||Reporter:||Dan Callaghan <dcallagh>|
|Component:||scheduler||Assignee:||Dan Callaghan <dcallagh>|
|Status:||CLOSED CURRENTRELEASE||QA Contact:||Dan Callaghan <dcallagh>|
|Version:||24||CC:||achatter, dcallagh, j-nomura, mjia, rjoost|
|Target Milestone:||24.4||Keywords:||Patch, Triaged|
|Fixed In Version:||Doc Type:||If docs needed, set a value|
|Doc Text:||Story Points:||---|
|Last Closed:||2017-10-03 03:57:52 UTC||Type:||Bug|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
Description Dan Callaghan 2017-07-14 06:57:31 UTC
Bug 889065 tried to avoid deadlocks between multi-host recipe sets with related host requirements, by using a very blunt hammer: any recipe in a recipe set that has been scheduled, will be given higher priority over any recipe that is not. This was achieved by adding .order_by(RecipeSet.lab_controller == None) in the schedule_queued_recipes routine, when it is looking for candidate recipes ready to be scheduled. This effectively sorts any recipe where recipe_set.lab_controller has been set to the top of the list. This attribute is set when the first recipe in the set is scheduled. As an example: RS:1 R:2 (requires system-a) R:3 (requires system-b) RS:4 R:5 (requires system-a) R:6 (requires system-b) Initially system-a and system-b are both busy. Then system-a becomes free, and R:2 is scheduled onto it (since its id is lower, assuming RS:1 and RS:4 are equal priority). Then system-b becomes free, and R:3 *should* be scheduled onto it, regardless of any other factors such as priority. This is the .order_by() fix for bug 889065. *However* this fix assumes that all potentially deadlocking recipes will be selected by the query -- and thus just tweaking the ordering of the results is enough to ensure the correct recipe is fixed. One of the filter criteria in all scheduler criteria is to exclude dirty jobs. This dates to when beakerd was running update_dirty_jobs concurrently with the scheduling routines (bug 807237), although we later had to serialize it to avoid database deadlocks even between unrelated jobs (bug 952587). In the example above, if RS:1 and RS:4 are part of a much larger job including unrelated recipe sets which have already started running (and thus the harness is marking the jobs dirty as it sends new results), then at each scheduling pass either R:2 or R:5 could be excluded randomly from the query. If R:2 is excluded because it is dirty but R:5 is not dirty, then the scheduler will pick R:5 instead, defeating the .order_by() and leading to deadlock.
Comment 1 Dan Callaghan 2017-07-14 06:59:17 UTC
The obvious solution is to just remove the criterion which is filtering out dirty jobs from the scheduler queries. By definition the harness cannot be sending updates for a recipe that is still queued. But I'm not sure if that could break things in some other way.
Comment 2 Dan Callaghan 2017-09-21 01:51:44 UTC
(In reply to Dan Callaghan from comment #1) I dug into this option in more detail and I think it is safe. That is, allowing the scheduler queries (for moving recipes from New through to Scheduled) to operate on jobs which are "dirty", instead of filtering down to "clean" jobs. These scheduler passes only select the individual recipes or recipe sets, and then operate on those alone without touching other parts of the job. So there should be no way the scheduler can conflict with harness updates happening on other recipes in the job which are already running. Anyway, we'll find out soon enough if it causes any problems... https://gerrit.beaker-project.org/5847
Comment 4 Dan Callaghan 2017-09-29 11:26:25 UTC
Given that this is very timing-sensitive across the scheduler *and* harness updates running concurrently in other recipe sets, there is no good way to reproduce this outside the test suite. Therefore I think the best way can do is to mark this VERIFIED based on the fact that the scheduler hasn't shown any odd behaviour in testing.
Comment 5 Dan Callaghan 2017-10-03 03:57:52 UTC
Beaker 24.4 has been released.