Bug 1471139

Summary: mariadb library upgrade to 10.2 causes mysql++ FTBFS
Product: [Fedora] Fedora Reporter: Augusto Caringi <acaringi>
Component: mysql++Assignee: Björn Persson <bjorn>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, bjorn, jwakely, warren
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-21 19:14:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1467297    
Attachments:
Description Flags
Patch to allow compilation of mysql++ with MariaDB 10.2 none

Description Augusto Caringi 2017-07-14 13:45:57 UTC 
Created attachment 1298334 [details]
Patch to allow compilation of mysql++ with MariaDB 10.2

Trying to build mysql++ with the new version of MariaDB 10.2 causes a build error:

./lib/dbdriver.cpp:260:10: error: 'CLIENT_LONG_PASSWORD' was not declared in this scope
    (o >= CLIENT_LONG_PASSWORD) &&
          ^~~~~~~~~~~~~~~~~~~~
./lib/dbdriver.cpp:260:10: note: suggested alternative: 'CLIENT_LONG_FLAG'
    (o >= CLIENT_LONG_PASSWORD) &&
          ^~~~~~~~~~~~~~~~~~~~
          CLIENT_LONG_FLAG

In this new version of the library the define CLIENT_LONG_PASSWORD was dropped. I attached a patch proposal to fix the problem.

We are tracking all the possible problems regarding this MariaDB upgrade in the bug 1467297.

Copr build: https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/package/mysql++/
Comment 1 Adam Williamson 2017-07-21 18:45:51 UTC 
Upstream ticket: https://tangentsoft.com/mysqlpp/tktview?name=4f077284dd

I have posted a link to the patch there.
Comment 2 Adam Williamson 2017-07-21 19:14:28 UTC 
Rawhide build with patch complete: https://koji.fedoraproject.org/koji/taskinfo?taskID=20650496
Comment 3 Warren Young 2017-09-08 17:44:40 UTC 
This is fixed upstream in checkin [e5f2c3d83f]. The trunk currently contains MySQL++ 3.2.3 plus some low-risk changes you may also want, so it is up to you whether you ship the MySQL++ trunk or maintain this patch in your 3.2.3 package until the next version of MySQL++ comes out, which will have this patch.
Comment 4 Warren Young 2018-07-28 14:05:27 UTC 
MySQL++ 3.2.4 is out with a fix for this, as well as other improvements to track changes in the external world: new OSes, new C++ compilers, and new versions of MariaDB.

It's a bug fix only release, so it should be safe to drop in place of 3.2.3.
Comment 5 Björn Persson 2018-08-09 17:36:56 UTC 
For your information, MySQL++ 3.2.4 is now built in Rawhide and will be included in Fedora 29.