Bug 1471206

Summary: mariadb library upgrade to 10.2 causes vdr-scraper2vdr FTBFS
Product: [Fedora] Fedora Reporter: Augusto Caringi <acaringi>
Component: vdr-scraper2vdrAssignee: MartinKG <mgansser>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, mgansser
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-21 18:41:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1467297    
Attachments:
Description Flags
Patch to allow compilation of vdr-scraper2vdr with MariaDB 10.2 none

Description Augusto Caringi 2017-07-14 16:58:52 UTC 
Created attachment 1298509 [details]
Patch to allow compilation of vdr-scraper2vdr with MariaDB 10.2

Trying to build vdr-scraper2vdr with the new version of MariaDB 10.2 causes a build error:

db.c: In member function 'int cDbConnection::errorSql(cDbConnection*, const char*, MYSQL_STMT*, const char*)':
db.c:1347:17: error: 'CR_INVALID_CONN_HANDLE' was not declared in this scope
        error == CR_INVALID_CONN_HANDLE ||
                 ^~~~~~~~~~~~~~~~~~~~~~
db.c:1347:17: note: suggested alternative: 'CR_INVALID_BUFFER_USE'
        error == CR_INVALID_CONN_HANDLE ||
                 ^~~~~~~~~~~~~~~~~~~~~~
                 CR_INVALID_BUFFER_USE
db.c:1351:17: error: 'CR_CONN_UNKNOW_PROTOCOL' was not declared in this scope
        error == CR_CONN_UNKNOW_PROTOCOL ||
                 ^~~~~~~~~~~~~~~~~~~~~~~
db.c:1351:17: note: suggested alternative: 'CR_CONN_UNKNOWN_PROTOCOL'
        error == CR_CONN_UNKNOW_PROTOCOL ||
                 ^~~~~~~~~~~~~~~~~~~~~~~
                 CR_CONN_UNKNOWN_PROTOCOL

In this new version of the library the define CR_CONN_UNKNOW_PROTOCOL was renamed to CR_CONN_UNKNOWN_PROTOCOL and the define CR_INVALID_CONN_HANDLE was dropped. I attached a patch proposal to fix the problem.

We are tracking all the possible problems regarding this MariaDB upgrade in the bug 1467297.

Copr build: https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/package/vdr-scraper2vdr/
Comment 1 MartinKG 2017-07-20 15:05:00 UTC 
successfully build for rawhide
https://koji.fedoraproject.org/koji/taskinfo?taskID=20629445
Comment 2 Adam Williamson 2017-07-21 18:41:44 UTC 
If its successfully built we can close the bug, nothing else is needed for Rawhide.