Bug 1471561

Summary:	Review Request: python-oletools - Tools to analyze Microsoft OLE2 files
Product:	[Fedora] Fedora	Reporter:	Michal Ambroz <rebus>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rebus, redhat-bugzilla, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-23 13:31:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1409648, 1471557, 1498616, 1498629, 1498637
Bug Blocks:	1500072

Description Michal Ambroz 2017-07-16 23:17:14 UTC

Spec URL: https://rebus.fedorapeople.org/SPECS/python-oletools.spec
SRPM URL: https://rebus.fedorapeople.org/SRPMS/python-oletools-0.51-1.fc25.src.rpm
Fedora Account System Username: rebus
Description: 
The python-oletools is a package of python tools from Philippe Lagadec
to analyze Microsoft OLE2 files (also called Structured Storage,
Compound File Binary Format or Compound Document File Format),
such as Microsoft Office documents or Outlook messages, mainly for
malware analysis, forensics and debugging.
It is based on the olefile parser.

Comment 1 Michal Ambroz 2017-07-16 23:28:10 UTC

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20564767

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-08-09 20:37:39 UTC

No need to define %sum: just use Summary normally, and then %summary wherever necessary.

I'd do something like
%global _description \
The python-oletools is a package of python tools from Philippe Lagadec\
to analyze Microsoft OLE2 files (also called Structured Storage,\
...

%description %_description
%description -n python2-%{gitname} %_description
%description -n python3-%{gitname} %_description
to avoid repeating the same text 3 times.

Are you sure that both python2 and python3 versions of the executables should be installed? I'd expect to get the same output from either version, so it should be enough to just package one of them (python2 it seems).
If you package both, it'd be better to use the suffixes recommended by https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin:
-3.6, -3, -2.7, -2.

/usr/lib/python3.6/site-packages/oletools/LICENSE.txt
should be marked as %license, and
/usr/lib/python3.6/site-packages/oletools/README.rst
/usr/lib/python3.6/site-packages/oletools/README.html
should be in %doc or removed.

It seems you also need
Provides: bundled(DridexUrlDecoder)
Provides: bundled(tablestream)
Provides: bundled(xglob)
Provides: bundled(xxxswf)
Provides: bundled(zipfile27)

Comment 3 Robert Scheck 2017-10-04 20:22:32 UTC

Michal, ping? Are you still interested in python-oletools?

Comment 4 Robert Scheck 2017-10-05 21:59:17 UTC

Based on #description and comment #2, I am suggesting the following changes:

Spec URL: https://labs.linuxnetz.de/bugzilla/python-oletools.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/python-oletools-0.51-2.src.rpm

Comment 5 Zbigniew Jędrzejewski-Szmek 2017-10-06 07:12:35 UTC

Hmm, I completely forgot about this. Robert, if Michal doesn't respond in a few days, open a new review ticket with your version, and close this one as duplicate of the new one.

Comment 6 Robert Scheck 2017-10-23 12:55:35 UTC

Zbigniew, I filed bug #1505374 now (14+ days since last discussion).

Comment 7 Zbigniew Jędrzejewski-Szmek 2017-10-23 13:31:14 UTC


*** This bug has been marked as a duplicate of bug 1505374 ***