Bug 1471598

Summary: Review Request: grub-theme-vimix - a beautiful theme for grub2
Product: [Fedora] Fedora Reporter: Junwei Fang <fjw201198>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora, ngompa13, package-review, robinlee.sysu
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-10 00:56:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841, 201449    

Description Junwei Fang 2017-07-17 03:56:40 UTC
Spec URL: http://mirrors.zhanfang.org/SRPMS/g/grub-theme-vimix-0.1.spec
SRPM URL: http://mirrors.zhanfang.org/SRPMS/g/grub-theme-vimix-0.1-1.src.rpm
Description: grub-them-vimix is n beautiful grub theme.
Fedora Account System Username: junwei

Comment 1 Junwei Fang 2017-07-17 05:04:43 UTC
task info:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20568445

Comment 3 Junwei Fang 2017-07-17 05:12:05 UTC
This is my first package, and I'm seeking a sponsor. Thank you.

Comment 4 Artur Frenszek-Iwicki 2017-07-19 10:29:10 UTC
>Group: Applications
>BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
The Group: and BuildRoot: tags should not be used. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>License: GPL
You need to specify the licence version.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL

>Source0: %{name}-%{version}.tar.gz
Downloadable URLs are preferred. If not possible, have a comment describing how to generate the tarball.
https://fedoraproject.org/wiki/Packaging:SourceURL

>grub2-mkconfig
I believe this calls for a "Requires: grub2-tools".

Comment 5 Fedora End Of Life 2017-11-16 19:18:30 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 6 Package Review 2020-07-10 00:55:57 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2020-08-10 00:56:51 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.