Bug 1471747

Summary: ddns updates broken since rebuild with bind99 9.9.10
Product: [Fedora] Fedora Reporter: Fabrice Bellet <fabrice>
Component: bind99Assignee: Petr Menšík <pemensik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: high    
Version: 25CC: jason.donald.burgess, jpopelka, mruprich, msehnout, nkudriavtsev, pemensik, pzhukov, thozza
Target Milestone: ---Keywords: Regression, Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: bind99-9.9.10-2.P3.fc25 bind99-9.9.10-2.P3.fc24 bind99-9.9.10-2.P3.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-24 15:51:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
revert context onrun change
none
dns_client_startupdate can be called twice again none

Description Fabrice Bellet 2017-07-17 11:44:40 UTC
It seems that ddns updates are no longer performed by dhcpd since its been rebuilt against bind99 9.9.10. From my experience, it comes from the function dns_client_startupdate() that slightly changed since 9.9.9 : in the newer version, a call to isc__app_ctxonrun() returns error 35 (already running) instead of calling startupdate() where the code has been moved to.

Comment 1 Pavel Zhukov 2017-07-17 15:08:19 UTC
Created attachment 1299909 [details]
revert context onrun change

Comment 2 Pavel Zhukov 2017-07-17 15:17:36 UTC
Thank you for reporting the issue. 
Bind is moving to use application context [1] for multithreading while dhcp is not there yet. Attaching simple patch to fix this particular issue but we'll see more until bz#1457871 is implemented.

[1] https://lists.isc.org/pipermail/bind-users/2015-February/094636.html

(gdb) bt
#0  isc__app_ctxonrun (ctx0=0x7ffff7ecf010, mctx=0x5555558440e0, task=0x7ffff7ed40d0, action=0x7ffff741ea03 <startupdate>, arg=0x7ffff7f01010)
    at ../../../../lib/isc/unix/app.c:415  <== 

414		if (ctx->running) {
415			result = ISC_R_ALREADYRUNNING;
416			goto unlock;
417		}

#1  0x00007ffff6f98ed1 in isc_app_ctxonrun (ctx=0x7ffff7ecf010, mctx=0x5555558440e0, task=0x7ffff7ed40d0, action=0x7ffff741ea03 <startupdate>, arg=0x7ffff7f01010)
    at ../../../lib/isc/app_api.c:100

[call stack output omitted]


#16 0x00007ffff6fb5ced in evloop (ctx=0x7ffff7ecf010) at ../../../../lib/isc/unix/app.c:515
#17 0x00007ffff6fb603c in isc__app_ctxrun (ctx0=0x7ffff7ecf010) at ../../../../lib/isc/unix/app.c:723 <<===

	if (!ctx->running) {
		ctx->running = ISC_TRUE;

		/*
		 * Post

Comment 3 Petr Menšík 2017-07-17 16:04:39 UTC
Yes, that is bug I brought in by update of Bind libraries. I think it is missing commit https://source.isc.org/cgi-bin/gitweb.cgi?p=bind9.git;a=commit;h=fbfaa3e731ec73b6ae35de36725e0f870759f8a8, which is not included in rebased version. I am sorry for that regression.

Comment 4 Petr Menšík 2017-07-17 16:19:36 UTC
Created attachment 1299948 [details]
dns_client_startupdate can be called twice again

Comment 5 Fedora Update System 2017-07-17 17:14:29 UTC
bind99-9.9.10-2.P3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-173edea419

Comment 6 Fabrice Bellet 2017-07-17 20:59:53 UTC
This update works fine for me, thank you!

Comment 7 Fedora Update System 2017-07-19 04:25:44 UTC
bind99-9.9.10-2.P3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-173edea419

Comment 8 Fedora Update System 2017-07-19 20:23:40 UTC
bind99-9.9.10-2.P3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-07-23 06:55:07 UTC
bind99-9.9.10-2.P3.fc24, dhcp-4.3.4-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-59127a606c

Comment 10 Fedora Update System 2017-07-27 19:50:50 UTC
bind99-9.9.10-2.P3.fc24, dhcp-4.3.4-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2017-08-21 11:36:30 UTC
bind99-9.9.10-2.P3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-75b1d4b623

Comment 12 Fedora Update System 2017-08-23 09:02:48 UTC
bind99-9.9.10-2.P3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-75b1d4b623

Comment 13 Fedora Update System 2017-08-24 15:51:34 UTC
bind99-9.9.10-2.P3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Pavel Zhukov 2018-03-28 14:23:23 UTC
*** Bug 1475289 has been marked as a duplicate of this bug. ***