Bug 1471885
| Summary: | Review Request: oci-umount - OCI umount hook for docker | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Frantisek Kluknavsky <fkluknav> |
| Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-26 19:53:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Frantisek Kluknavsky
2017-07-17 15:05:14 UTC
rpmlint ./oci-umount-debuginfo-1.13-101.git7623f6a.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint ./oci-umount-1.13-101.git7623f6a.fc27.x86_64.rpm oci-umount.x86_64: W: obsolete-not-provided docker-oci-umount <= This is intentional. docker-oci-umount was a typo and got released by mistake. Nothing should depend on it. oci-umount.x86_64: W: only-non-binary-in-usr-lib oci-umount.x86_64: W: hidden-file-or-dir /usr/lib/.build-id oci-umount.x86_64: W: hidden-file-or-dir /usr/lib/.build-id <= This is a false positive according to https://bugzilla.redhat.com/show_bug.cgi?id=1431408 1 packages and 0 specfiles checked; 0 errors, 4 warnings. rpmlint ./oci-umount-1.13-101.git7623f6a.fc27.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint ./oci-umount.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. * Why do you need Epoch?
* Missing BuildRequires: gcc
* %configure --libexecdir=/usr/libexec/oci/hooks.d/ -> %configure --libexecdir=%{_libexecdir}/oci/hooks.d
* make %{?_smp_mflags} -> %make_build
* %{!?_licensedir:%global license %doc} <-- remove this
* %dir /%{_libexecdir}/oci <-- no need for slash, it just makes it unreadable
Oci-umount is currently built as a subpackage of docker. Docker rpm sadly has epoch. I do not think we can get rid of it. Gcc added to BuildRequires. I wrongly assumed that gcc is included by default. Thank you. Libexec macro used. %make_build used. %global license removed Extra slashes removed (readability is a bit subjective though). Thank you for the comments. Updated files at: https://fedorapeople.org/~fkluknav/oci-umount.spec https://fedorapeople.org/~fkluknav/oci-umount-1.13-102.git7623f6a.fc27.src.rpm > Docker rpm sadly has epoch. I do not think we can get rid of it.
When you are obsoleting something, doesn't matter which Epoch it has, you still can obsolete it.
BTW, you should include Epoch in Obsoletes, otherwise it will not obsolete it.
this can be fixed during import, so APPROVED.
You were right with epoch in Obsoletes, it does not work without epoch. I still do not think we can get rid of epoch in this new package. Docker-oci-umount is obsoleted, no problem, it existed for a short period of time. Then it was renamed to oci-umount. It is still a subpackage of docker, has the same version and epoch as docker, and has the same name as this new package request. The point of this request is to restore order in the chaotic docker packaging and create a proper new component with the same name. If I understand things correctly, I can not meaningfully obsolete a package with exactly the same name. Am I wrong? (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oci-umount oci-umount-2.0.0-2.gitf90b64c.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-333f924756 oci-umount-2.0.0-2.gitf90b64c.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-94e852e79d oci-umount-2.0.0-2.gitf90b64c.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-333f924756 oci-umount-2.0.0-2.gitf90b64c.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-94e852e79d oci-umount-2.0.0-2.gitf90b64c.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. oci-umount-2.0.0-2.gitf90b64c.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |