Bug 1472619

Summary: Platform Dependent Python Import
Product: Red Hat Enterprise Linux 7 Reporter: Oneata Mircea Teodor <toneata>
Component: pki-coreAssignee: Christian Heimes <cheimes>
Status: CLOSED ERRATA QA Contact: Asha Akkiangady <aakkiang>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 7.4CC: cheimes, mharmsen, msauton, pbokoc, ssidhaye, tlavigne
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pki-core-10.4.1-12.el7_4 Doc Type: No Doc Update
Doc Text:
Fixed pylint for Python 3 on platforms that require it.
Story Points: ---
Clone Of: 1463916 Environment:
Last Closed: 2017-09-05 11:25:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1463916    
Bug Blocks:    

Description Oneata Mircea Teodor 2017-07-19 06:28:44 UTC
This bug has been copied from bug #1463916 and has been proposed to be backported to 7.4 z-stream (EUS).

Comment 3 Sumedh Sidhaye 2017-08-10 13:48:11 UTC
Build used for verification:

Name        : pki-server
Version     : 10.4.1
Release     : 12.el7_4
Architecture: noarch
Install Date: Thursday 10 August 2017 09:30:33 AM EDT
Group       : System Environment/Base
Size        : 4649492
License     : GPLv2
Signature   : (none)
Source RPM  : pki-core-10.4.1-12.el7_4.src.rpm
Build Date  : Friday 04 August 2017 08:46:41 PM EDT
Build Host  : ppc-015.build.eng.bos.redhat.com
Relocations : (not relocatable)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
Vendor      : Red Hat, Inc.
URL         : http://pki.fedoraproject.org/
Summary     : Certificate System - PKI Server Framework


Here are the /usr/lib/python2.7/site-packages/pki/client.py contents

import requests
try:
    from requests.packages.urllib3.exceptions import InsecureRequestWarning
except ImportError:
    from urllib3.exceptions import InsecureRequestWarning


Is this sufficient for verifying this bug or do I need to check any other files ?

Comment 4 Matthew Harmsen 2017-08-10 23:08:49 UTC
(In reply to Sumedh Sidhaye from comment #3)
> Build used for verification:
> 
> Name        : pki-server
> Version     : 10.4.1
> Release     : 12.el7_4
> Architecture: noarch
> Install Date: Thursday 10 August 2017 09:30:33 AM EDT
> Group       : System Environment/Base
> Size        : 4649492
> License     : GPLv2
> Signature   : (none)
> Source RPM  : pki-core-10.4.1-12.el7_4.src.rpm
> Build Date  : Friday 04 August 2017 08:46:41 PM EDT
> Build Host  : ppc-015.build.eng.bos.redhat.com
> Relocations : (not relocatable)
> Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
> Vendor      : Red Hat, Inc.
> URL         : http://pki.fedoraproject.org/
> Summary     : Certificate System - PKI Server Framework
> 
> 
> Here are the /usr/lib/python2.7/site-packages/pki/client.py contents
> 
> import requests
> try:
>     from requests.packages.urllib3.exceptions import InsecureRequestWarning
> except ImportError:
>     from urllib3.exceptions import InsecureRequestWarning
> 
> 
> Is this sufficient for verifying this bug or do I need to check any other
> files ?


As this RHEL 7.4.z bug was cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1463916, if you look at that bug, you will see that this replacement code was installed to fix a pylint issue that occurred on Fedora 27.

As RHEL 7.4 does not use Python 3, checking that the code change is present and does not hinder the RHEL 7.4 system should be sufficient.

Comment 5 Sumedh Sidhaye 2017-08-14 02:38:05 UTC
Verified that pki commands are not affected by this change.
Marking this bug verified.

Comment 7 errata-xmlrpc 2017-09-05 11:25:02 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2575