Bug 1472824

Related tickets: #1470699 (update to rubygem-jekyll)
#1470702 (another jekyll extension)
#1310368 (my prior request for jekyll including this module, fortunately overtaken by someone else's packaging fo it)

Hello,

 - Version: is 0.11.0 but version in %changelog (and upstream) is 0.12.1. Did you forget to update the tag?

 - The Group: tag is not used in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - You didn't fill the %changelog entry with your name and email.

* Tue Jul 04 2017 John Heidemann <johnh> - 0.12.1-1

 - The %check section is currently not testing anything, missing "rspec spec/" ?
 
   For this, some dependencies are missing, I remember reviewing jekyll-sitemap so I already have a rpm laying around. It is not yet in Rawhide because it depend on the jekyll update. Rubocop has a review request but it doesn't seem mandatory.
   However the jekyll-sitemap packaged is a 1.x version, and the compatibility with such version is only available on a recent GIT snapshot: https://github.com/jekyll/jekyll-redirect-from/commit/55b91b3748f53679697225e07a62688baf9a917c

   Thus I suggest you to package the latest development snapshot:

   First:

%global commit          bc5ab9bd672e005f59ae6beabe8cbce5c77e0cdc
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global commitdate      20170731


  Then:

Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}

  With the following source:
 
# git clone https://github.com/jekyll/jekyll-redirect-from/
# cd jekyll-redirect-from; gem build jekyll-redirect-from.gemspec
Source0: %{gem_name}-%{version}.gem


  And the corresponding changelog entry:

* Tue Sep 12 2017 John Heidemann <johnh> - 0.12.1-0.1.20170731gitbc5ab9b


Of course, it will depend on the jekyll update going through (bug #1470699) then the sitemap package being imported (bug #1470702).

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

SPEC and SRPM's urls are expired

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.