Bug 1473133
| Summary: | dht/cluster: rebalance/remove-brick should honor min-free-disk | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Susant Kumar Palai <spalai> |
| Component: | distribute | Assignee: | Susant Kumar Palai <spalai> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.10 | CC: | bugs, nbalacha |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.10.5 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1441508 | Environment: | |
| Last Closed: | 2017-08-21 13:41:22 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1441508 | ||
| Bug Blocks: | 1360317, 1473132 | ||
|
Description
Susant Kumar Palai
2017-07-20 05:49:31 UTC
REVIEW: https://review.gluster.org/17832 (cluster/dht: Skip file migration if the subvol that meets min-free-disk criteria happens to be the same subvol containing data-file) posted (#1) for review on release-3.10 by Susant Palai (spalai) REVIEW: https://review.gluster.org/17833 (cluster/dht: correct space check for rebalance) posted (#1) for review on release-3.10 by Susant Palai (spalai) REVIEW: https://review.gluster.org/17832 (cluster/dht: Skip file migration if the subvol that meets min-free-disk) posted (#2) for review on release-3.10 by Susant Palai (spalai) REVIEW: https://review.gluster.org/17833 (cluster/dht: correct space check for rebalance) posted (#2) for review on release-3.10 by Susant Palai (spalai) REVIEW: https://review.gluster.org/17832 (cluster/dht: Skip file migration if the subvol that meets min-free-disk) posted (#3) for review on release-3.10 by Shyamsundar Ranganathan (srangana) COMMIT: https://review.gluster.org/17832 committed in release-3.10 by Shyamsundar Ranganathan (srangana) ------ commit 7daeae73d9edfa181f8e86394fb6dfc68b22440f Author: Susant Palai <spalai> Date: Mon Apr 17 13:00:54 2017 +0530 cluster/dht: Skip file migration if the subvol that meets min-free-disk ... criteria happens to be the same subvol containing data-file Rebalance need to figure out a new subvol in case the hashed subvol does not have enough space. In the process of figuring out the new subvol, we need to ignore the source subvol, otherwise it will lead to data loss. Test: Manual Ran the following sizeof /tmp/1: 1.5GB sizeof /brick/1: 16GB sizeof /tmp/2: 1.5GB <start> glusterd; gluster v create test1 vm1:/brick/1 vm1:/tmp/1; gluster v start test1; mount -t glusterfs vm1:test1 /mnt; for i in {1..2000} do dd if=/dev/zero of=/mnt/file$i bs=1KB count=1 &> /dev/null; done gluster v add-brick test1 vm1:/tmp/2 gluster v set test1 min-free-disk 12GB gluster v remove-brick test1 vm1:/tmp/1 star <end> file count and data were intact. > Change-Id: Ib8fc8467a3d48a7c12958824c4f0b88e160b86c1 > BUG: 1441508 > Signed-off-by: Susant Palai <spalai> > Reviewed-on: https://review.gluster.org/17064 > Smoke: Gluster Build System <jenkins.org> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Raghavendra G <rgowdapp> > Signed-off-by: Susant Palai <spalai> Change-Id: Ib8fc8467a3d48a7c12958824c4f0b88e160b86c1 BUG: 1473133 Signed-off-by: Susant Palai <spalai> Reviewed-on: https://review.gluster.org/17832 Smoke: Gluster Build System <jenkins.org> Tested-by: Shyamsundar Ranganathan <srangana> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: https://review.gluster.org/17833 (cluster/dht: correct space check for rebalance) posted (#3) for review on release-3.10 by Shyamsundar Ranganathan (srangana) COMMIT: https://review.gluster.org/17833 committed in release-3.10 by Shyamsundar Ranganathan (srangana) ------ commit 967171f76dc91bf23bc7853147975ac882881039 Author: Susant Palai <spalai> Date: Mon Apr 24 16:27:23 2017 +0530 cluster/dht: correct space check for rebalance With rebalance doing fallocate on destination, we don't need to add file size to the "destination available space" to decide whether to migrate the file or not. Notes: Fallocate would have already occupied the file size space on destination > Change-Id: If7f6a6654e6257726680cf20d618482a6e9095a6 > BUG: 1441508 > Signed-off-by: Susant Palai <spalai> > Reviewed-on: https://review.gluster.org/17104 > Smoke: Gluster Build System <jenkins.org> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Amar Tumballi <amarts> > Reviewed-by: N Balachandran <nbalacha> > Reviewed-by: Raghavendra G <rgowdapp> > Signed-off-by: Susant Palai <spalai> Change-Id: If7f6a6654e6257726680cf20d618482a6e9095a6 BUG: 1473133 Signed-off-by: Susant Palai <spalai> Reviewed-on: https://review.gluster.org/17833 CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.5, please open a new bug report. glusterfs-3.10.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-August/000079.html [2] https://www.gluster.org/pipermail/gluster-users/ |