Bug 1473384

Summary:	Review Request: rubygem-jekyll-lunr-js-search
Product:	[Fedora] Fedora	Reporter:	František Zatloukal <fzatlouk>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, vondruch, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-16 06:11:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description František Zatloukal 2017-07-20 16:31:26 UTC

SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00581821-rubygem-jekyll-lunr-js-search/rubygem-jekyll-lunr-js-search.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00581821-rubygem-jekyll-lunr-js-search/rubygem-jekyll-lunr-js-search-3.3.0-1.fc26.src.rpm

This package won't be installable without rubygem-rubyracer >= 0.12 (not built for > F25 at all, 0.11 is in F24).

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-07-24 18:28:07 UTC

rubygem-rubyracer was retired last year: http://pkgs.fedoraproject.org/cgit/rpms/rubygem-therubyracer.git/diff/dead.package?id=4206bd0748385b34151f4f5f636dc1644f97ec95. 

You wrote:
> The other option would be to patch upstream jekyll-lunr-js-search to rely
> for JS on rubygem-execjs instead of rubygem-therubyracer or strip out search
> completely (which is broken right now anyway in packaged version).

Yeah, that's an option too. How hard would it be?

Comment 2 František Zatloukal 2017-07-25 13:30:51 UTC

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Yeah, that's an option too. How hard would it be?

Not much probably but I don't have any Ruby experience. I've tried to code something around but everything failed in the end.

I am adding some stuff that might help users interested in porting:

https://github.com/discourse/mini_racer - pointed out by vondruch, maintained alternative to therubyracer, but API is different

https://github.com/huginn/huginn/pull/1961/commits/b1c4e5a6c8237b49e63f9a2b6e69883ae4ff3f4d#diff-ebbdd90260f85855146205da3872662c - PR of random project ported from therubyracer to mini_racer

Comment 3 Package Review 2020-07-10 00:56:00 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.