Bug 1473606

Summary: Cancelled delayed plans are not picked up by cleaner rake task when using AFTER
Product: Red Hat Satellite Reporter: Adam Ruzicka <aruzicka>
Component: Tasks PluginAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2.9CC: aruzicka, inecas, jcallaha
Target Milestone: UnspecifiedKeywords: FieldEngineering, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-04 17:45:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Adam Ruzicka 2017-07-21 09:37:34 UTC
Description of problem:
When trying to remove cancelled delayed plans using the foreman_tasks:cleanup AFTER=$AFTER, it will skip those plans because they don't have started_at field set.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Schedule remote execution job to be executed in the future
2. Go to its task and click cancel
3. Observe task flipping over to stopped-error
5. Run foreman-rake foreman_tasks:cleanup AFTER='10s'

Actual results:
The task remains there

Expected results:
The task is deleted

Additional info:


Workaround: 
Modify your cleanup cronjob/script to look like this

AFTER='30d' # Set desired time interval here

# Run your normal cleanup here
# foreman-rake foreman_tasks:cleanup AFTER=$AFTER ...

# Let the cleanup task compute the right cutoff date
TIMESTAMP="$(foreman-rake foreman_tasks:cleanup TASK_SEARCH='label != a_label' NOOP=true AFTER="$AFTER" | grep 'all tasks matching' | grep -P -o "\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d" | tail -n1)"

# Remove the broken leftovers
foreman-rake foreman_tasks:cleanup TASK_SEARCH="null? started_at AND ended_at < \"$TIMESTAMP\""

Comment 1 Adam Ruzicka 2017-07-21 09:42:16 UTC
Created redmine issue http://projects.theforeman.org/issues/20375 from this bug

Comment 3 Bryan Kearney 2018-09-04 17:45:07 UTC
Thank you for your interest in Satellite 6. We have evaluated this request, and we do not expect this to be implemented in the product in the foreseeable future. We are therefore closing this out as WONTFIX. If you have any concerns about this, please feel free to contact Rich Jerrido or Bryan Kearney. Thank you.