Bug 1473635

Summary: systemd considers suspend to fail, despite seeming to work fine
Product: [Fedora] Fedora Reporter: Alan Jenkins <alan.christopher.jenkins>
Component: systemdAssignee: systemd-maint
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: johannbg, lnykryn, martin, msekleta, muadda, ssahani, s, systemd-maint, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-29 12:06:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alan Jenkins 2017-07-21 10:50:42 UTC
Description of problem:

systemd considers suspend.target as failed, despite an apparently successful suspend.

Version-Release number of selected component (if applicable):
systemd-233-6.fc26.x86_64

How reproducible: always


Steps to Reproduce:
1. systemctl suspend
2. Wake the system by pressing the power button.
3. systemctl status suspend.target

Actual results:

$ systemctl status suspend.target
● suspend.target - Suspend
   Loaded: loaded (/usr/lib/systemd/system/suspend.target; static; vendor preset: disabled)
   Active: inactive (dead)
     Docs: man:systemd.special(7)

Jul 21 11:39:56 alan-laptop systemd[1]: suspend.target: Bound to unit systemd-suspend.service, but unit isn't active.
Jul 21 11:39:56 alan-laptop systemd[1]: Dependency failed for Suspend.
Jul 21 11:39:56 alan-laptop systemd[1]: suspend.target: Job suspend.target/start failed with result 'dependency'.


Expected results:

Job suspend.target/start does not fail, during a successful suspend/resume cycle.


Additional info:

I think this is an oversight in how the systemd sleep units are written.  I can't immediately think of a solution.

I think the problem is that systemd-suspend.service goes inactive after resume, and the BindsTo dependency in suspend.target means this causes the target to transition to a failed state.

But I'm not familiar with the exact purpose of the BindsTo dependency in suspend.target.


$ systemctl status systemd-suspend.service
● systemd-suspend.service - Suspend
   Loaded: loaded (/usr/lib/systemd/system/systemd-suspend.service; static; vendor preset: disabled)
   Active: inactive (dead)
     Docs: man:systemd-suspend.service(8)

Jul 21 11:39:52 alan-laptop systemd[1]: Starting Suspend...
Jul 21 11:39:52 alan-laptop systemd-sleep[7812]: Suspending system...
Jul 21 11:39:56 alan-laptop systemd[1]: Started Suspend.

$ systemctl list-dependencies -a suspend.target
suspend.target
● └─systemd-suspend.service
●   ├─system.slice
●   │ └─-.slice
●   └─sleep.target

Comment 1 Alan Jenkins 2017-07-21 11:00:30 UTC
Huh, it looks like some change in systemd behaviour of BindsTo, after a very recent package update.  (Possibly the upgrade to Fedora 26):

journalctl -u suspend.target
...
Jul 13 19:07:48 alan-laptop systemd[1]: Reached target Suspend.
Jul 13 19:07:48 alan-laptop systemd[1]: suspend.target: Unit is bound to inactive unit systemd-suspend.service. Stopping, too.
Jul 13 19:07:48 alan-laptop systemd[1]: Stopped target Suspend.
-- Reboot --
Jul 13 22:28:16 alan-laptop systemd[1]: suspend.target: Bound to unit systemd-suspend.service, but unit isn't active.
Jul 13 22:28:16 alan-laptop systemd[1]: Dependency failed for Suspend.
...

Comment 2 Alan Jenkins 2017-07-21 11:11:49 UTC
As far as I can tell this issue is eligible for tracking by upstream, so I reported https://github.com/systemd/systemd/issues/6419

Comment 3 Fedora End Of Life 2018-05-03 08:41:33 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 4 Alan Jenkins 2018-05-03 12:38:25 UTC
I can confirm this no longer happens in Fedora 28.

Fixed in systemd 235, commit https://github.com/systemd/systemd/commit/64a36ae4b1dd23474dd7ea261381ac437b24fac2

Comment 5 Fedora End Of Life 2018-05-29 12:06:00 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.