Bug 1473970

Summary:	dynazoom graph not working with munin-cgi-graph after recent security fix
Product:	[Fedora] Fedora	Reporter:	Peter "Pessoft" Kolínek <pessoft>
Component:	munin	Assignee:	d. johnson <drjohnson1>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	26	CC:	dan, drjohnson1, ingvar, jvanek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-29 12:55:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter "Pessoft" Kolínek 2017-07-22 20:59:53 UTC

Description of problem:

When dynamic graph is being open via dynazoom it sends upper and lower limits to generate the graph images as empty values. This fails since the fix in parsing of input parameters of munin-cgi-graph. This has been however solved in the upstream stable-2.0 branch already.

Version-Release number of selected component (if applicable):
munin-2.0.30-5.fc26.noarch

How reproducible:
Install munin-2.0.30-5.fc26.noarch and open some graph in detail view - via dynazoom.html.

Steps to Reproduce:
1. Open munin web interface
2. Select some host
3. Select some monitored service graph
4. Select some time range graph

Actual results:
dynazoom.html is opened, but munin-cgi-graph image is not rendered.

Expected results:
dynazoom.html is opened and munin-cgi-graph image is rendered and displayed.

Additional info:
Debug information shows that upper_limit received an empty value and has been passed to rrdtool. This is already fixed in upstream ( just few days after initial security fix ) so munin-cgi-graph checks whether it received numerical value in upper/lower_limit parameters.

Comment 1 Dan Alderman 2017-08-28 17:00:57 UTC

I have the same issue.  I think it's down to this:

2017/08/28 17:24:03 [RRD ERROR] Unable to graph @@CGITMPDIR@@/munin-cgi-graph/wobble.com/wibble.wobble.com/sensors_temp-pinpoint=1469376632,1503936632.png?&lower_limit=&upper_limit=&size_x=800&size_y=400 : option -l - Cannot convert '' to float

Which I think has been closed upstream by:

https://github.com/munin-monitoring/munin/commit/549bd25d6a45e153159ef8535fc070a71093a3c9

so we need a version bump?

Comment 2 Fedora End Of Life 2018-05-03 08:39:39 UTC

This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2018-05-29 12:55:55 UTC

Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.