Bug 1474403

Summary:	Review Request: perl-Env-ShellWords - Environment variables for arguments as a Perl array
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Env-ShellWords-0.01-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 12:56:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1474425

Description Petr Pisar 2017-07-24 14:15:32 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Env-ShellWords/perl-Env-ShellWords.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Env-ShellWords/perl-Env-ShellWords-0.01-1.fc27.src.rpm
Description:
This Perl module provides an array-like interface to environment variables that
contain flags. For example Autoconf can uses the environment variables like
CFLAGS or LDFLAGS, and this allows you to manipulate those variables
without doing space quoting and other messy mucky stuff.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-08-01 08:53:04 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Env-ShellWords-0.01-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(Text::ParseWords)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Env-ShellWords-0.01-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Env::ShellWords) = 0.01
      1 perl-Env-ShellWords = 0.01-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Env-ShellWords*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-08-01 12:26:44 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Env-ShellWords

Comment 3 Petr Pisar 2017-08-01 12:56:11 UTC

Thank you for the review and the repository.