Bug 1474427
Summary: | Embedded Ansible role will not start if worker is killed during setup run | |||
---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Nick Carboni <ncarboni> | |
Component: | Appliance | Assignee: | Nick Carboni <ncarboni> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | luke couzens <lcouzens> | |
Severity: | high | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 5.8.0 | CC: | abellott, cpelland, jhardy, lcouzens, obarenbo | |
Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
Target Release: | 5.9.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ansible_embed:black | |||
Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1474835 (view as bug list) | Environment: | ||
Last Closed: | 2018-03-06 15:18:50 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1474835 |
Description
Nick Carboni
2017-07-24 15:08:29 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/cd863fd86318aa9a0366457b6402f8fa4fca8a92 commit cd863fd86318aa9a0366457b6402f8fa4fca8a92 Author: Nick Carboni <ncarboni> AuthorDate: Mon Jul 24 15:28:31 2017 -0400 Commit: Nick Carboni <ncarboni> CommitDate: Mon Jul 24 16:42:02 2017 -0400 Add a marker file for determining when the ansible setup has been run This ensures that we have a definitive way to determine if we have successfully run the setup for embedded ansible on a particular server Before this change, the thread running the setup could be killed and when we tried to start the service again, we would see #configured? as true even if we didn't run through the whole playbook. Now, we will not write this marker file until we finish running the playbook so the next worker will know to attempt the setup if the previous one was killed. https://bugzilla.redhat.com/show_bug.cgi?id=1474427 lib/embedded_ansible.rb | 21 +++++++++++++++++++++ spec/lib/embedded_ansible_spec.rb | 15 ++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-) Verified in 5.9.0.2 |