Bug 1474457

Summary:	Please build catch for EPEL7
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	catch	Assignee:	Tom Hughes <tom>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ignatenko, projects.rg, tom
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-24 16:43:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Orion Poplawski 2017-07-24 16:37:03 UTC

Description of problem:

Please build catch for EPEL7 - only change needed is:

diff --git a/catch.spec b/catch.spec
index fc65b3c..59235cb 100644
--- a/catch.spec
+++ b/catch.spec
@@ -9,7 +9,7 @@ License:        Boost
 URL:            https://github.com/philsquared/Catch
 Source0:        https://github.com/philsquared/Catch/archive/v%{version}/%{name}-%{version}.tar.gz

-BuildRequires:  cmake make gcc-c++
+BuildRequires:  cmake3 make gcc-c++

 %description
 Catch stands for C++ Automated Test Cases in Headers and is a
@@ -34,7 +34,7 @@ is packaged up as a single header for extra convenience.


 %build
-%cmake . -Bbuild
+%cmake3 . -Bbuild
 %make_build -Cbuild


which works for Fedora as well.

Comment 1 Tom Hughes 2017-07-24 16:43:54 UTC

If you want to request ACLs for EPEL branches then please feel free but I don't do EPEL stuff myself.

Comment 2 Orion Poplawski 2017-07-24 17:13:26 UTC

Done.  Do you mind me making the above changes to the Fedora branch?

Comment 3 Igor Gnatenko 2017-07-24 17:14:37 UTC

(In reply to Orion Poplawski from comment #2)
> Done.  Do you mind me making the above changes to the Fedora branch?

I'm not maintainer of catch (sigh). But being one who doesn't do EPEL stuff myself, I would be against.

Comment 4 Tom Hughes 2017-07-24 17:18:09 UTC

I can't say I'm particularly keen either.

Branch request has been approved anyway.