Bug 1475282

Summary:	[Remove-brick] Few files are getting migrated eventhough the bricks crossed cluster.min-free-disk value
Product:	[Community] GlusterFS	Reporter:	Susant Kumar Palai <spalai>
Component:	distribute	Assignee:	Susant Kumar Palai <spalai>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	amukherj, bugs, rcyriac, rhinduja, rhs-bugs, smallamp, storage-qa-internal, tdesala
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1474812
Clones:	1477152 (view as bug list)		Environment:
Last Closed:	2017-12-08 17:35:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1474812
Bug Blocks:	1477152

Comment 1 Worker Ant 2017-07-26 11:52:24 UTC

REVIEW: https://review.gluster.org/17876 (cluster/dht: rebalance min-free-disk fix) posted (#1) for review on master by Susant Palai (spalai)

Comment 2 Susant Kumar Palai 2017-07-26 11:53:33 UTC

upstream patches:
https://review.gluster.org/#/c/17876/
https://review.gluster.org/#/c/17868/

Comment 3 Worker Ant 2017-07-27 07:20:19 UTC

REVIEW: https://review.gluster.org/17876 (cluster/dht: rebalance min-free-disk fix) posted (#2) for review on master by Susant Palai (spalai)

Comment 4 Worker Ant 2017-07-27 12:34:19 UTC

REVIEW: https://review.gluster.org/17868 (cluster/dht: Handle wrong rebalance status reporting) posted (#3) for review on master by Susant Palai (spalai)

Comment 5 Worker Ant 2017-07-31 10:12:23 UTC

REVIEW: https://review.gluster.org/17876 (cluster/dht: rebalance min-free-disk fix) posted (#3) for review on master by Susant Palai (spalai)

Comment 6 Worker Ant 2017-07-31 10:27:42 UTC

REVIEW: https://review.gluster.org/17868 (cluster/dht: Handle wrong rebalance status reporting) posted (#4) for review on master by Susant Palai (spalai)

Comment 7 Worker Ant 2017-08-01 06:10:18 UTC

COMMIT: https://review.gluster.org/17876 committed in master by Raghavendra G (rgowdapp) 
------
commit c7cc5049fc8965836926a6f1b3a3270ad1aa566d
Author: Susant Palai <spalai>
Date:   Wed Jul 26 17:12:03 2017 +0530

    cluster/dht: rebalance min-free-disk fix
    
    To calculate available space on a subvolume we used to do
    the following in __dht_check_free_space.
    
    post_availspace = (dst_statfs.f_bavail * dst_statfs.f_frsize) - stbuf->ia_size
    
    Now to subtracting the file size from available space is tricky here.
    Sometime available space will be lesser than the file size and since all the
    participating members in calculation are unsigned int, the result is a large
    number (integer overflow).
    
    Solution: We do not need to subtract the file size from the space available,
    since fallocate would have reserved file size space already.
    
    Change-Id: I4f724358c44b9911933742ff3ff8d55b3dfda1cb
    BUG: 1475282
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: https://review.gluster.org/17876
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: N Balachandran <nbalacha>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 8 Worker Ant 2017-08-01 06:24:08 UTC

REVIEW: https://review.gluster.org/17868 (cluster/dht: Handle wrong rebalance status reporting) posted (#5) for review on master by Raghavendra G (rgowdapp)

Comment 9 Worker Ant 2017-08-01 06:54:39 UTC

COMMIT: https://review.gluster.org/17868 committed in master by Raghavendra G (rgowdapp) 
------
commit ed0a3acfccbbfc96f417d8dba880e3d070bb0043
Author: Susant Palai <spalai>
Date:   Thu Jul 27 16:33:12 2017 +0530

    cluster/dht: Handle wrong rebalance status reporting
    
    Change-Id: Id91ef35f890055cd42b9a94462f92297c77f1fff
    Bug: 1475282
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: https://review.gluster.org/17868
    Tested-by: Raghavendra G <rgowdapp>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
    Smoke: Gluster Build System <jenkins.org>

Comment 10 Shyamsundar 2017-12-08 17:35:59 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/