Bug 1475444

Summary:	virt-viewer stops responding after multiple USB sticks with same vendor are used.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Bill Sanford <bsanford>
Component:	mingw-virt-viewer	Assignee:	Victor Toso <victortoso>
Status:	CLOSED ERRATA	QA Contact:	SPICE QE bug list <spice-qe-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.1.4	CC:	apinnick, astepano, cfergeau, dblechte, djasa, lsurette, rbalakri, rduda, srevivo, tpelka, victortoso
Target Milestone:	ovirt-4.2.0
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	mingw-virt-viewer-2.0-15.el7ev mingw-spice-gtk-0.31-8.el7ev	Doc Type:	Bug Fix
Doc Text:	Previously, if more than one device from the same vendor and with the same device ID was plugged in, the device change signal was ignored and the client became unresponsive when the redirected (first) USB device was removed. The current release ensures that each USB device is unique, so that multiple devices from the same vendor and with the same device ID are redirected and the client does not become unresponsive.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-15 18:02:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Spice	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1425961
Bug Blocks:

Description Bill Sanford 2017-07-26 17:22:16 UTC

Description of problem:
As in bug 1425961, I use 2 USB thumb drives and only see one. The first one is plugged in and seen and the second thumb drive is not seen. After the two are in, I then take the first USB drive that is in the guest, and virt-viewer gets into a non-responding state, indefinitely. 

Version-Release number of selected component (if applicable):
RHEL-7.4-20170711.0
rhv-4.1.4-2
rhev-guest-tools-iso-4.1-5

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

I think when the https://bugzilla.redhat.com/show_bug.cgi?id=1425961 is fixed, this should be a non-issue since the USB sticks will be able to be used like other ones without the same IDs.

Comment 1 Christophe Fergeau 2017-07-27 06:54:45 UTC

Wondering if it could be https://bugzilla.redhat.com/show_bug.cgi?id=1475444

Comment 2 Christophe Fergeau 2017-07-27 06:55:01 UTC

Sorry, meant https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=3fb475a9c9eac077c9eebb3623fe14b4cd1e965a

Comment 3 Victor Toso 2017-11-30 17:32:39 UTC

(In reply to Christophe Fergeau from comment #2)
> Sorry, meant
> https://cgit.freedesktop.org/spice/spice-gtk/commit/
> ?id=3fb475a9c9eac077c9eebb3623fe14b4cd1e965a

This seems useful fix to have backported so I'll take it with this bug.

Bill, running with gdb on windows to get the backtrace could confirm if commit in comment #2 is indeed the right fix here.

Comment 4 Victor Toso 2017-11-30 17:34:26 UTC

David, could you please qa_ack?

Comment 5 Victor Toso 2017-12-11 10:38:44 UTC

Fixing virt-viewer version that this bug should really be fixed. Previous build did not pick the correct dependencies with the backported patches.

Comment 6 Sandro Bonazzola 2017-12-12 13:54:43 UTC

Please check if this can be moved to ON_QA

Comment 7 Victor Toso 2017-12-12 14:13:35 UTC

(In reply to Sandro Bonazzola from comment #6)
> Please check if this can be moved to ON_QA

As mentioned in comment #5 - The patch that fixes this bug is on:
mingw-virt-viewer-2.0-15.el7ev
mingw-spice-gtk-0.31-8.el7ev

Comment 14 errata-xmlrpc 2018-05-15 18:02:00 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1543

Comment 15 Franta Kust 2019-05-16 13:04:51 UTC

BZ<2>Jira Resync