Bug 1475564

Summary: Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures
Product: [Fedora] Fedora Reporter: Kevin Fenzi <kevin>
Component: Package ReviewAssignee: Randy Barlow <randy>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: kevin, package-review, randy
Target Milestone: ---Flags: randy: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-14 16:25:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
review.txt
none
review-2.txt none

Description Kevin Fenzi 2017-07-26 22:07:58 UTC 
Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config.spec
SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config-1.2.11-1.fc27.src.rpm
Description: Simple configuration objects for Py.test fixtures
Fedora Account System Username: kevin

rpmlint says:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

koji scratch build:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

This package is needed for python-setuptools tests.
Comment 1 Randy Barlow 2017-07-27 15:32:56 UTC 
Created attachment 1305478 [details]
review.txt
Comment 2 Randy Barlow 2017-07-27 15:37:31 UTC 
There is only one thing that must be fixed for approval: the package does need py.test so it should Require it.

Other than that, I had a few optional suggestions:

* If you use github for Source0, you can include the LICENSE file. It introduces
  some other questions though, since the git repo contains other packages too. See
  the attached review.txt for details.
* I recommend filing a bug against python3 to get it to own the __pycache__ folder.

Anyways, I'm prepared to approve if you add the requirements on py.test.
Comment 3 Kevin Fenzi 2017-07-27 20:48:51 UTC 
ok, -2 at the same place with the requires added:

Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config.spec
SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config-1.2.11-2.fc27.src.rpm

I thought about using the github project, but I think that would just complicate things more since all those other things are there in the same repo.
Comment 4 Randy Barlow 2017-07-27 21:10:39 UTC 
Created attachment 1305655 [details]
review-2.txt
Comment 5 Randy Barlow 2017-07-27 21:10:54 UTC 
Looks good!
Comment 6 Gwyn Ciesla 2017-08-13 22:47:06 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-fixture-config
Comment 7 Gwyn Ciesla 2017-08-13 22:48:22 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-fixture-config