Bug 1475791
| Summary: | Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <eclipseo> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-28 22:22:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1473314 | ||
|
Description
Robert-André Mauchin 🐧
2017-07-27 11:29:03 UTC
Fixed ExclusiveArch issue Spec URL: https://github.com/eclipseo/packaging/blob/27b7add/golang-github-VividCortex-ewma.spec SRPM: https://kojipkgs.fedoraproject.org//work/tasks/2023/20802023/golang-github-VividCortex-ewma-0-0.1.git4cc8cc5.fc27.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20802021 Upstream already fixed the bug and released an update. Spec URL: https://github.com/eclipseo/packaging/blob/27c38cc/golang-github-VividCortex-ewma.spec SRPM: https://kojipkgs.fedoraproject.org//work/tasks/4305/20804305/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20804304 SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584409-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584409-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm FAS username: eclipseo Taking this. I've found some minor issues:
1) Please don't remove the commit and shortcommit variables generated by gofed. They are used to do automatic version tracking of golang packages in fedora, even if they aren't part of the version string.
You can include something like this (look at some of my golang packages, e.g. golang-github-calmh-du) to clarify that the version is exactly this commit:
%global commit b24eb346a94c3ba12c1da1e564dbac1b498a77ce
%global shortcommit %(c=%{commit}; echo ${c:0:7})
# commit b24eb346a94c3ba12c1da1e564dbac1b498a77ce == version 1.1.1
2) Please don't use the "ugly" Source0 URL. There's a really nice way to get tarballs of tags (without doing the #/XXX.tar.gz hack):
Source0: https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz
This generates a tarball of the commit tagged with "v%{version}" with the name "%{project}-%{version}.tar.gz" - which is exactly what you want, without hacks.
See (under GitHub): https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags
PS: For some golang projects, you might consider naming the tarball "%{project}-%{repo}.tar.gz" in the Source URL, especially if the name %{repo} is ambiguous, or if there's already a package with that name. That way you won't run into possible collisions in the source lookaside cache. It's not an issue with this package, but keep it in mind.
Otherwise:
Package Review
==============
[x]: Package complies to the Packaging Guidelines
Please fix the 2 issues I pointed out, then the package is ready for approval.
Okay done: SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591472-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591472-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm Thanks for your review! Package complies with Guidelines, and you've fixed the 2 issues I pointed out. Approved. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-VividCortex-ewma golang-github-VividCortex-ewma-1.1.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a91dca49f golang-github-VividCortex-ewma-1.1.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f62d7b0d87 golang-github-VividCortex-ewma-1.1.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a91dca49f golang-github-VividCortex-ewma-1.1.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. golang-github-VividCortex-ewma-1.1.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |