Bug 1475863

Summary: Review Request: golang-github-xanzy-ssh-agent - Create a ssh-agent on any type of OS from any Go application
Product: [Fedora] Fedora Reporter: Robert-André Mauchin 🐧 <zebob.m>
Component: Package ReviewAssignee: Peter Lemenkov <lemenkov>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: lemenkov, package-review
Target Milestone: ---Flags: lemenkov: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-11 02:25:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1473314    

Description Robert-André Mauchin 🐧 2017-07-27 13:38:54 UTC
SPEC: https://github.com/eclipseo/packaging/blob/c6f5edb/golang-github-xanzy-ssh-agent.spec
SRPM: https://kojipkgs.fedoraproject.org//work/tasks/712/20800712/golang-github-xanzy-ssh-agent-0-0.1.gitba9c9e3.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20800711

Description: Create a ssh-agent on any type of OS from any Go application

FAS username: eclipseo

This package is needed by rclone, bug #1473314.

Thanks.

Comment 4 Peter Lemenkov 2017-08-28 13:41:32 UTC
I'll review it

Comment 5 Peter Lemenkov 2017-08-28 13:44:14 UTC
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines (it was generated by gofed utility)
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (ASL 2.0, https://www.apache.org/licenses/LICENSE-2.0).
+ The file, containing the text of the license(s) for the package, is included as %license.
+ The spec file is written in American English.
+ The spec file for the package is legible as much as it applies to autogenerated stuff (just use gofed to regenerate it).
+ The sources used to build the package, match the upstream source, as provided in the spec URL.

Auriga ~/rpmbuild/SOURCES: sha256sum ssh-agent-ba9c9e3.tar.gz*
6c9fd37e4a401ac431ff174fa4bd3df8a81d652ac96b627a58a3e13d06b73bcb  ssh-agent-ba9c9e3.tar.gz
6c9fd37e4a401ac431ff174fa4bd3df8a81d652ac96b627a58a3e13d06b73bcb  ssh-agent-ba9c9e3.tar.gz.1
Auriga ~/rpmbuild/SOURCES: 

+ The package successfully compiles and builds into binary rpms on at least one primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No C/C++ header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files without a suffix (e.g. libfoo.so) in some of the dynamic linker's default paths.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other packages.
+ All filenames in rpm packages are valid UTF-8.


APPROVED.

Comment 6 Gwyn Ciesla 2017-09-01 19:18:19 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-xanzy-ssh-agent

Comment 7 Fedora Update System 2017-09-02 15:06:30 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-793b275eec

Comment 8 Fedora Update System 2017-09-02 15:08:16 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e02b68b3e

Comment 9 Fedora Update System 2017-09-02 15:10:41 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2703e7b297

Comment 10 Fedora Update System 2017-09-03 05:24:58 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e02b68b3e

Comment 11 Fedora Update System 2017-09-03 06:26:10 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2703e7b297

Comment 12 Fedora Update System 2017-09-03 19:55:28 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-793b275eec

Comment 13 Fedora Update System 2017-09-11 02:25:43 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-09-11 04:20:56 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-09-30 06:13:32 UTC
golang-github-xanzy-ssh-agent-0-0.1.20151215gitba9c9e3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.