Bug 1476365
| Summary: | NTP config file doesn't change after clearing the NTP servers settings | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Martin Kourim <mkourim> | |
| Component: | Appliance | Assignee: | Brandon Dunne <bdunne> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Parthvi Vala <pvala> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 5.8.0 | CC: | abellott, bdunne, jhardy, obarenbo, smallamp, tpapaioa | |
| Target Milestone: | GA | Keywords: | TestOnly | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | configuration:appliance | |||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1517959 (view as bug list) | Environment: | ||
| Last Closed: | 2018-06-21 20:47:00 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1517959 | |||
|
Description
Martin Kourim
2017-07-28 17:36:22 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/2a28c6fca39d1fba8d7625f36ce1bbd97535d1c9 commit 2a28c6fca39d1fba8d7625f36ce1bbd97535d1c9 Author: Brandon Dunne <bdunne> AuthorDate: Mon Oct 2 14:56:30 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon Oct 2 14:56:30 2017 -0400 Move default NTP server settings from constant to Settings Part of: https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/zone.rb | 8 ++------ config/settings.yml | 5 +++++ spec/models/miq_server_spec.rb | 3 +-- spec/models/zone_spec.rb | 4 +++- 4 files changed, 11 insertions(+), 9 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0679d67c2a7805b8c50b16c084ad3374853904f1 commit 0679d67c2a7805b8c50b16c084ad3374853904f1 Author: Brandon Dunne <bdunne> AuthorDate: Wed Oct 11 16:27:28 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Oct 20 11:42:48 2017 -0400 Add a method to easily delete settings_changes for a resource https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/mixins/configuration_management_mixin.rb | 21 ++++++++++++++++----- spec/models/miq_region_spec.rb | 15 +++++++++++++++ .../miq_server/configuration_management_spec.rb | 15 +++++++++++++++ spec/models/zone_spec.rb | 15 +++++++++++++++ 4 files changed, 61 insertions(+), 5 deletions(-) New commit detected on ManageIQ/manageiq-schema/master: https://github.com/ManageIQ/manageiq-schema/commit/4fe2aba783fddb2b2e4d8599f8ad641d3bacac88 commit 4fe2aba783fddb2b2e4d8599f8ad641d3bacac88 Author: Brandon Dunne <bdunne> AuthorDate: Mon Nov 6 11:43:49 2017 -0500 Commit: Brandon Dunne <bdunne> CommitDate: Mon Nov 6 11:43:49 2017 -0500 Migrate Zone NTP settings to SettingsChanges https://bugzilla.redhat.com/show_bug.cgi?id=1476365 ...103212526_move_zone_ntp_settings_to_settings.rb | 31 +++++++++++++ ...2526_move_zone_ntp_settings_to_settings_spec.rb | 53 ++++++++++++++++++++++ 2 files changed, 84 insertions(+) create mode 100644 db/migrate/20171103212526_move_zone_ntp_settings_to_settings.rb create mode 100644 spec/migrations/20171103212526_move_zone_ntp_settings_to_settings_spec.rb New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/9dc07c5e9945907f034393097c3301d7cf87a0db commit 9dc07c5e9945907f034393097c3301d7cf87a0db Author: Brandon Dunne <bdunne> AuthorDate: Thu Nov 2 14:41:06 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 15:33:35 2017 -0400 No more need for server_ntp_settings Everything is pulled from Settings now https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/miq_server/ntp_management.rb | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/a49a4b84021635131c154f7f7cf36dfedbc7b191 commit a49a4b84021635131c154f7f7cf36dfedbc7b191 Author: Brandon Dunne <bdunne> AuthorDate: Thu Nov 2 15:17:45 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 15:33:45 2017 -0400 NTP settings won't be blank and it doesn't matter where they're set https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/miq_server/ntp_management.rb | 9 --------- 1 file changed, 9 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/9bb69cc10dd841f79b7be5c2b999db0bfcad6d7e commit 9bb69cc10dd841f79b7be5c2b999db0bfcad6d7e Author: Brandon Dunne <bdunne> AuthorDate: Thu Nov 2 14:41:49 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 15:33:39 2017 -0400 Use the default arg for ntp_reload https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/miq_server/queue_management.rb | 1 - app/models/zone.rb | 1 - 2 files changed, 2 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/194f8a65fe6e5eeef3b948556a3d9ad6f6af0827 commit 194f8a65fe6e5eeef3b948556a3d9ad6f6af0827 Author: Brandon Dunne <bdunne> AuthorDate: Thu Nov 2 16:38:46 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 15:33:50 2017 -0400 These settings are no longer stored in the settings column https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/zone.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/cb453e1520108088d846fa7cc9cc0254be16fc6c commit cb453e1520108088d846fa7cc9cc0254be16fc6c Author: Brandon Dunne <bdunne> AuthorDate: Fri Nov 3 11:38:21 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 16:43:12 2017 -0400 Move queue_ntp_reload_if_changed from a callback to a method We are no longer using the `settings` column on the record so the callback is no longer valid. https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/zone.rb | 32 ++++++------------------ spec/models/zone_spec.rb | 63 +++++++++++++++++------------------------------- 2 files changed, 30 insertions(+), 65 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/3263499caf64cf0df5a8b6297e0d24fb151c3463 commit 3263499caf64cf0df5a8b6297e0d24fb151c3463 Author: Brandon Dunne <bdunne> AuthorDate: Fri Nov 3 11:39:11 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 16:43:18 2017 -0400 server_ntp_settings_blank? is no longer used, there's always a setting https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/miq_server/ntp_management.rb | 5 ----- 1 file changed, 5 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/e22c02d2527185d7906db3711777d408a32df3fa commit e22c02d2527185d7906db3711777d408a32df3fa Author: Brandon Dunne <bdunne> AuthorDate: Fri Nov 3 11:40:24 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 16:43:18 2017 -0400 Fetch the ntp_settings from within the method There is now only one caller, so no reason to be an independent method https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/models/miq_server/ntp_management.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/bb78c4b7179edb9e1d4fffb4f567ca7bbd906e3c commit bb78c4b7179edb9e1d4fffb4f567ca7bbd906e3c Author: Brandon Dunne <bdunne> AuthorDate: Fri Nov 3 17:02:25 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 17:03:09 2017 -0400 Add a test to verify the file is only updated when settings have changed https://bugzilla.redhat.com/show_bug.cgi?id=1476365 spec/models/miq_server_spec.rb | 7 +++++++ 1 file changed, 7 insertions(+) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/b0e2a9fc474d2496702ee1c105f56039cc5945ec commit b0e2a9fc474d2496702ee1c105f56039cc5945ec Author: Brandon Dunne <bdunne> AuthorDate: Fri Nov 3 16:58:18 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Nov 3 17:03:00 2017 -0400 Update MiqServer NTP tests to not be concerned with testing Settings https://bugzilla.redhat.com/show_bug.cgi?id=1476365 spec/models/miq_server_spec.rb | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/ec979abdbb950c45bc8b6dffb012277ae23040fb commit ec979abdbb950c45bc8b6dffb012277ae23040fb Author: Brandon Dunne <bdunne> AuthorDate: Fri Nov 3 14:56:23 2017 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Tue Nov 7 15:31:36 2017 -0500 Queue a ntp_reload for all servers in the zone that was updated This used to be a callback when the NTP settings were stored in the settings column on a zone. Now that they are in Settings, move the reload to the method that changes the settings. https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/controllers/ops_controller/settings/zones.rb | 2 ++ 1 file changed, 2 insertions(+) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/2aca23319eb2a9c3fdf335212c762d58f3584e3c commit 2aca23319eb2a9c3fdf335212c762d58f3584e3c Author: Brandon Dunne <bdunne> AuthorDate: Tue Nov 7 15:29:23 2017 -0500 Commit: Brandon Dunne <bdunne> CommitDate: Tue Nov 7 15:31:41 2017 -0500 Move the settings save call to ensure the record has an ID for association https://bugzilla.redhat.com/show_bug.cgi?id=1476365 app/controllers/ops_controller/settings/zones.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/81b28641eda2ed481f3907e4ebb0c8f872dcf073 commit 81b28641eda2ed481f3907e4ebb0c8f872dcf073 Author: Brandon Dunne <bdunne> AuthorDate: Tue Dec 5 16:48:39 2017 -0500 Commit: Brandon Dunne <bdunne> CommitDate: Tue Dec 5 16:48:39 2017 -0500 Cache invalidation... Typically changes are made in the UI and work is queued for another worker to write the file. Ensure that the worker has the latest settings before writing the changes to the file. https://bugzilla.redhat.com/show_bug.cgi?id=1517959 app/models/miq_server/ntp_management.rb | 2 ++ 1 file changed, 2 insertions(+) |