Bug 1476592
| Summary: | RHV provider VM Quad icon page: VM power 'reset' option do not fail as expected. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ilanit Stein <istein> | ||||||
| Component: | Providers | Assignee: | Moti Asayag <masayag> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Angelina Vasileva <anikifor> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 5.8.0 | CC: | gblomqui, jfrey, jhardy, obarenbo, simaishi | ||||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||||
| Target Release: | 5.9.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | rhev | ||||||||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1503639 (view as bug list) | Environment: | |||||||
| Last Closed: | 2018-03-06 14:52:35 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | Bug | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | RHEVM | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1503639 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ilanit Stein
2017-07-30 14:58:48 UTC
Created attachment 1306610 [details]
VM_reset_flash_message
Created attachment 1306611 [details]
VM_reset_task
https://github.com/ManageIQ/manageiq-providers-ovirt/pull/78 https://github.com/ManageIQ/manageiq-ui-classic/pull/1924 New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/4dbc186b02469bd85f519df9fc90290db560ea57 commit 4dbc186b02469bd85f519df9fc90290db560ea57 Author: Moti Asayag <masayag> AuthorDate: Tue Aug 15 19:16:49 2017 +0300 Commit: Moti Asayag <masayag> CommitDate: Wed Aug 23 10:54:03 2017 +0300 Block unsupported VMs reset When selecting VMs to be reset via the VMs center dialog, no validation is done for the selected VMs. Therefore VMs which doesn't meet the criteria and would block such action if applied on a VM specific, can be selected and later on failed. A pre-check is added to make sure VMs which doesn't meet the expected terms for reset are prevented from being reset. https://bugzilla.redhat.com/show_bug.cgi?id=1476592 app/controllers/application_controller/ci_processing.rb | 9 +++++++++ spec/controllers/vm_infra_controller_spec.rb | 15 +++++++++++++++ 2 files changed, 24 insertions(+) New commit detected on ManageIQ/manageiq-providers-ovirt/master: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/7cef4f0850ec21ae8fa2607453014deb6292c1b4 commit 7cef4f0850ec21ae8fa2607453014deb6292c1b4 Author: Moti Asayag <masayag> AuthorDate: Tue Aug 15 19:21:22 2017 +0300 Commit: Moti Asayag <masayag> CommitDate: Tue Aug 15 19:21:22 2017 +0300 Block unsupported VMs reset RHV doesn't support VM reset action and should block it when VMs are being selected for reset via the VMs center dialog. https://bugzilla.redhat.com/show_bug.cgi?id=1476592 app/models/manageiq/providers/redhat/infra_manager/vm.rb | 1 + 1 file changed, 1 insertion(+) Verified on CFME-5.9.0.4/RHV-4.1.6. When running on VMs Quad icon display Power option "reset", it fails on: "Reset does not apply to at least one of the selected items" New commit detected on ManageIQ/manageiq-ui-classic/fine: https://github.com/ManageIQ/manageiq-ui-classic/commit/67ffc5967335c9fa01c20eee2ef21c3cccf72761 commit 67ffc5967335c9fa01c20eee2ef21c3cccf72761 Author: Moti Asayag <masayag> AuthorDate: Sun Nov 5 21:06:00 2017 +0200 Commit: Moti Asayag <masayag> CommitDate: Sun Nov 5 21:06:00 2017 +0200 [FINE] Block unsupported VMs reset When selecting VMs to be reset via the VMs center dialog, no validation is done for the selected VMs. Therefore VMs which doesn't meet the criteria and would block such action if applied on a VM specific, can be selected and later on failed. A pre-check is added to make sure VMs which doesn't meet the expected terms for reset are prevented from being reset. This is a backport of https://github.com/ManageIQ/manageiq-ui-classic/pull/1924 https://bugzilla.redhat.com/show_bug.cgi?id=1476592 app/controllers/application_controller/ci_processing.rb | 10 ++++++++++ spec/controllers/vm_infra_controller_spec.rb | 11 +++++++++++ 2 files changed, 21 insertions(+) |