Bug 1476735

Summary:	Fix default setting of %_debugsource_packages and %_debuginfo_subpackages to not break testsuite
Product:	[Fedora] Fedora	Reporter:	Mark Wielaard <mjw>
Component:	rpm	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ignatenko, kardos.lubos, mjw, packaging-team-maint, vmukhame
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	redhat-rpm-config-67-1.fc27 rpm-4.13.0.1-41.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-31 14:01:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mark Wielaard 2017-07-31 10:06:51 UTC

Description of problem:

rpm-4.13.0.1-37 enabled %_debugsource_packages and %_debuginfo_subpackages by patching macros.in.

This caused the testsuite to fail since the tests are setup to selectively enable/disable these. The upstream default rpm settings are split like the fedora rpm/redhat-rpm-config settings. With macros.in setting the default and macros.debug for those tests that need debug packages.

Unfortunately this means that %check now ignores any test failures again. Which can catch build or toolchain issues.

The best fix, IMHO, would be to leave the upstream defaults alone and move the setting of %_debugsource_packages and %_debuginfo_subpackages to redhat-rpm-config default macros. This is also how other debug packages defaults are set like %_enable_debug_packages and %_include_minidebuginfo.

Comment 1 Igor Gnatenko 2017-07-31 10:08:00 UTC

I think we should just do --undefine from respective tests...

Comment 2 Mark Wielaard 2017-07-31 10:09:20 UTC

Somewhat related "macros should include %_include_gdb_index 1 to generate .gdb_index sections by default" https://bugzilla.redhat.com/show_bug.cgi?id=1476722 Probably good to fix these together.