Bug 1477547

Summary:	Gluster block should have log file path configurable
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Mohamed Ashiq <mliyazud>
Component:	gluster-block	Assignee:	Prasanna Kumar Kalever <prasanna.kalever>
Status:	CLOSED ERRATA	QA Contact:	Sweta Anandpara <sanandpa>
Severity:	high	Docs Contact:
Priority:	high
Version:	rhgs-3.3	CC:	amukherj, hchiramm, madam, pkarampu, prasanna.kalever, rcyriac, rhs-bugs, rtalur, sanandpa, storage-qa-internal
Target Milestone:	---
Target Release:	RHGS 3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	gluster-block-0.2.1-8.el7rhgs	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-21 04:20:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1417151, 1470521

Description Mohamed Ashiq 2017-08-02 11:29:14 UTC

Description of problem:
Gluster block should have log file path configurable.

In case of CNS we have to have separate two templates to support gluster-block and non gluster-block setup. If this option is configurable then we can configure the path of log file and use the pre-existing template to log for gluster-block also. This will also reduce the transition model, if some user wants to use gluster-block at some point of time.

Comment 14 Sweta Anandpara 2017-08-28 11:17:15 UTC

Please note how it has been tested on the gluster-block side. 

1. The environment variable GB_LOGDIR is set on the CLI(shell) side as well as for the daemon.
* CLI(shell): export GB_LOGDIR=/var/log/glusterfs/gluster-block
* Daemon: echo "GB_LOGDIR=/var/log/glusterfs/gluster-block" >> /etc/sysconfig/gluster-blockd
2. systemctl restart gluster-blockd
3 "ps eww <gluster-block-pid>" should show the new variable GB_LOGDIR and its value


The log files do show up in the new location /var/log/glusterfs/gluster-block. 

Case1: However all the old configuration related to old blocks continue to get logged in the old location '/var/log/gluster-block'.
I suppose this is expected as it is the nature of tcmu-runner logging. And I suppose this will not be hit in CNS if we are going to start it afresh with GB_LOGDIR correctly set.

Case2: I am setting the environment variable twice, for CLI as well as daemon. Doing just one of the two will log some files in the old location and some files in the new location. Please confirm if this is taken care of in the CNS environment.

@Raghavendra, please do write if any other scenarios need to be tested with this. Will be moving this bug to verified if you ack the concerns raised in Case1 and Case2.

Comment 15 Raghavendra Talur 2017-08-29 08:51:09 UTC

All log files should get logged under /var/log/glusterfs/gluster-block if it is a clean setup is what prasanna told me. Sweta, did you upgrade the setup from a previous version, if so that all old blocks that were created will continue to log to /var/log/gluster-block. 

Can you try on a fresh setup and verify please?

Comment 17 Sweta Anandpara 2017-08-29 09:51:28 UTC

Moving it to ASSIGNED as tcmu-runner logs continue to get copied in the older location '/var/log/gluster-block'

Comment 20 Sweta Anandpara 2017-08-30 05:26:36 UTC

Raised BZ 1486541 as per Comment 19. Moving the present BZ to verified in RHGS 3.3.0.

Comment 22 errata-xmlrpc 2017-09-21 04:20:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:2773