Bug 1477616

Summary:	Validation failed: Status is not included in the list
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	Greg McCullough <gmccullo>
Status:	CLOSED ERRATA	QA Contact:	Shveta <sshveta>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	5.7.0	CC:	bsorota, cpelland, dbomhof, gblomqui, gekis, gmccullo, jfrey, jhardy, mkanoor, obarenbo, tfitzger
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.8.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.8.2.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1460158	Environment:	5.7.2.1
Last Closed:	2017-10-24 00:16:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:	1460158
Bug Blocks:

Comment 3 CFME Bot 2017-08-02 16:11:22 UTC

New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/37d4f9db01f21467d145b7573f0ca84c8841000f

commit 37d4f9db01f21467d145b7573f0ca84c8841000f
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Jul 31 10:39:10 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Aug 2 12:06:03 2017 -0400

    Merge pull request #15685 from syncrou/no_longer_copy_denied_state
    
    Force status removal and default value
    (cherry picked from commit 7db49cd6f4fdda5cb7bc8dd384b731baf2dfec70)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1477616

 app/models/miq_request.rb       | 14 +++++++++++---
 app/models/miq_request_task.rb  |  1 +
 spec/models/miq_request_spec.rb | 15 +++++++++++++++
 3 files changed, 27 insertions(+), 3 deletions(-)

Comment 4 CFME Bot 2017-08-04 18:42:29 UTC

https://github.com/ManageIQ/manageiq/pull/15734

Comment 5 Shveta 2017-08-30 17:48:46 UTC

Looks like to recreate the issue , I need to have denied status in request table and then it needs to be copied .
Not sure how to recreate that.
Can i get the verification steps please .

Comment 6 Greg McCullough 2017-08-31 18:28:39 UTC

To validate create the service template as normal for a provider then you can use a modified form of one of the suggested work-arounds to cause the issue.

In the Rails console instead of doing this:
  MiqProvisionRequestTemplate.update_all(:status => "Ok")

set the status to the invalid "Denied" status:
  MiqProvisionRequestTemplate.update_all(:status => "Denied")

This is reproduce the service ordering error.

Comment 7 Shveta 2017-08-31 20:41:12 UTC

Was able to verify with the above steps .
No error seen in provisioning, request completed successfully.
Verified in 5.8.2.0.20170824192913_b09a5f8

Comment 9 errata-xmlrpc 2017-10-24 00:16:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3005