Bug 1478779

Summary:	fish package has an incomplete list of dependencies
Product:	[Fedora] Fedora	Reporter:	Audrey Yeena Toskin <audrey>
Component:	fish	Assignee:	Andy Lutomirski <luto>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	26	CC:	jaswinder, luto, oliver, oliver
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	fish-2.6.0-1.fc26 fish-2.6.0-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-15 20:08:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Audrey Yeena Toskin 2017-08-07 04:19:16 UTC

fish's default collection of commands and functionality assume the system has a lot more packages installed than their source installation guide would suggest. For example, tab completion uses the `apropos` command (from package man-db), which was not available even after I installed fish, in the minimal Fedora Atomic Host environment.

See this discussion on GitHub:
https://github.com/fish-shell/fish-shell/issues/2062

Comment 1 Audrey Yeena Toskin 2017-08-15 04:24:10 UTC

Okay, both of the pull requests I submitted against fish's build documentation have merged. I think the current dependency list should finally be complete... See the latest README upstream:

https://github.com/fish-shell/fish-shell#building

Comment 2 Fedora Update System 2017-10-09 15:45:20 UTC

fish-2.6.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-82f6fc0638

Comment 3 Fedora Update System 2017-10-09 15:45:57 UTC

fish-2.6.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0972f702e

Comment 4 Fedora Update System 2017-10-11 02:53:26 UTC

fish-2.6.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0972f702e

Comment 5 Fedora Update System 2017-10-11 06:27:52 UTC

fish-2.6.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-82f6fc0638

Comment 6 Audrey Yeena Toskin 2017-10-15 05:19:04 UTC

Sorry, I don't think the dependencies for the fish package are complete quite yet. Again, based on the newly documented runtime and build dependencies documented upstream -- https://github.com/fish-shell/fish-shell/blob/master/README.md -- I think you still need to add:

Requires: gawk
Requires: findutils
Requires: pcre2
Requires: ncurses
Requires: gettext
Requires: grep
Requires: coreutils
Requires: util-linux
Requires: procps-ng
Requires: sed

BuildRequires: gcc-c++
BuildRequires: muParser-devel

This is listed as optional, but I think it would be good to include it too. "Builtin commands that have the --help option or print usage messages require nroff and ul (manual page formatters) to do so." We could maybe call it a Recommends.

Recommends: groff-base

Comment 7 Fedora Update System 2017-11-15 20:08:11 UTC

fish-2.6.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2017-11-25 02:34:38 UTC

fish-2.6.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.