Bug 1478823

Summary:	openstacknet driver should not run on external network nics (conflicts with OVN)
Product:	[oVirt] ovirt-engine	Reporter:	Marcin Mirecki <mmirecki>
Component:	General	Assignee:	Marcin Mirecki <mmirecki>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mor <mkalfon>
Severity:	medium	Docs Contact:
Priority:	high
Version:	---	CC:	bugs, lveyde, mkalfon, ylavi
Target Milestone:	ovirt-4.1.6	Flags:	rule-engine: ovirt-4.1+
Target Release:	4.1.6.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-19 10:02:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcin Mirecki 2017-08-07 08:09:22 UTC

The openstacknet driver should not run/fail for nic managed by external providers.
The hook scripts of the openstacknet driver currenlty fail on checking the pluginType, which might not be present for external providers.
The hooks should exit right after checking that the provider type is not "OPENSTACK_NETWORK".

How to reproduce:
- install both openstacknet and an external provider (like the OVN provider)
- create an nic on the OVN provider, plug/unplug/migrate the nic
- the openstacknet hooks should not interfere with this

Comment 1 Mor 2017-09-11 09:22:04 UTC

Verified on RHV-H host:
ovirt-provider-ovn-driver-1.0-8.el7ev.noarch
Red Hat Virtualization Manager Version: 4.1.6.2-0.1.el7

VM hosted on the host with OVN network is able to run, and I am able to do hot-unpluing and hot-plug of vNIC.


Dom XML:
...
        <interface type="bridge">
            <address bus="0x00" domain="0x0000" function="0x0" slot="0x03" type="pci" />
            <mac address="00:1a:4a:16:20:c1" />
            <model type="virtio" />
            <source bridge="ovirtmgmt" />
            <filterref filter="vdsm-no-mac-spoofing" />
            <link state="up" />
            <bandwidth />
        </interface>
...

Comment 2 Mor 2017-09-11 09:23:10 UTC

(In reply to Mor from comment #1)
> Verified on RHV-H host:
> ovirt-provider-ovn-driver-1.0-8.el7ev.noarch
> Red Hat Virtualization Manager Version: 4.1.6.2-0.1.el7
> 
> VM hosted on the host with OVN network is able to run, and I am able to do
> hot-unpluing and hot-plug of vNIC.
> 
> 
> Dom XML:
> ...
>         <interface type="bridge">
>             <address bus="0x00" domain="0x0000" function="0x0" slot="0x03"
> type="pci" />
>             <mac address="00:1a:4a:16:20:c1" />
>             <model type="virtio" />
>             <source bridge="ovirtmgmt" />
>             <filterref filter="vdsm-no-mac-spoofing" />
>             <link state="up" />
>             <bandwidth />
>         </interface>
> ...

Just adding, the packages on the host were grabbed manually.