Bug 1478866

Summary:	No info that enabled nestedvt is really working
Product:	[oVirt] ovirt-engine	Reporter:	Jiri Belka <jbelka>
Component:	Frontend.WebAdmin	Assignee:	bugs <bugs>
Status:	CLOSED NOTABUG	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.1.5.1	CC:	bugs, jbelka, michal.skrivanek, mperina, tjelinek
Target Milestone:	---	Keywords:	TechPreview
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-09 07:23:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jiri Belka 2017-08-07 11:15:03 UTC

Description of problem:

One can enable nestedvt in Edit Host/Kernel but even after doing reinstall there's no info that such feature is working. Not sure how to do it, maybe a '!' if a setting is set but is not applied/working on the host?

Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-4.1.5.1-0.1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. add a host, activate it, put into maintenance
2. edit host, enable nestedvt
3. click Reinstall

Actual results:
host is up, nestedvt is enabled but in fact the feature is not "applied" (there was no reboot) and no info that the enabled feature is working is visible

Expected results:
'!' about need to do reboot to have nestedvt working or host should not become activated if the feature (nestedvt) cannot work

Additional info:

Comment 1 Michal Skrivanek 2017-08-08 07:06:06 UTC

It's a non supported hook so do not expect any fancy GUI support. 
Reboot should br suggested in the reinstall dialog, is it not?

Comment 2 Jiri Belka 2017-08-08 11:39:15 UTC

(In reply to Michal Skrivanek from comment #1)
> It's a non supported hook so do not expect any fancy GUI support. 
> Reboot should br suggested in the reinstall dialog, is it not?

enabling nestedvt, clicking Ok causes no info about need for reboot.

enabling nestedvt, clicking ok, putting host into maintenance, activating it causes no info/warning about nestedvt being enabled but not working on the host.

imo the latter scenario is even worse.

Comment 3 Tomas Jelinek 2017-08-08 16:02:20 UTC

I don't think we want to add also something more fancy than that...(In reply to Jiri Belka from comment #2)
> (In reply to Michal Skrivanek from comment #1)
> > It's a non supported hook so do not expect any fancy GUI support. 
> > Reboot should br suggested in the reinstall dialog, is it not?
> 
> enabling nestedvt, clicking Ok causes no info about need for reboot.

At the top of the dialog there is this big red message:

"Kernel boot parameters changes require host deploy and restart. The host needs to be REINSTALLED suceesfully and then to be REBOOTED for kernel boot parameters to be applied!"

Have it been shown for you? If yes, I don't think we want to get any more fancy than that.

> 
> enabling nestedvt, clicking ok, putting host into maintenance, activating it
> causes no info/warning about nestedvt being enabled but not working on the
> host.
> 
> imo the latter scenario is even worse.

Comment 4 Jiri Belka 2017-08-09 06:54:13 UTC

(In reply to Tomas Jelinek from comment #3)
> I don't think we want to add also something more fancy than that...(In reply
> to Jiri Belka from comment #2)
> > (In reply to Michal Skrivanek from comment #1)
> > > It's a non supported hook so do not expect any fancy GUI support. 
> > > Reboot should br suggested in the reinstall dialog, is it not?
> > 
> > enabling nestedvt, clicking Ok causes no info about need for reboot.
> 
> At the top of the dialog there is this big red message:
> 
> "Kernel boot parameters changes require host deploy and restart. The host
> needs to be REINSTALLED suceesfully and then to be REBOOTED for kernel boot
> parameters to be applied!"
> 
> Have it been shown for you? If yes, I don't think we want to get any more
> fancy than that.
> 
> > 
> > enabling nestedvt, clicking ok, putting host into maintenance, activating it
> > causes no info/warning about nestedvt being enabled but not working on the
> > host.
> > 
> > imo the latter scenario is even worse.

ok, it is there. although i still there could be a regular check like we do for power mgmt or some checks for VMs which cause appearance of '!'...

Comment 5 Tomas Jelinek 2017-08-09 07:23:40 UTC

> ok, it is there. although i still there could be a regular check like we do
> for power mgmt or some checks for VMs which cause appearance of '!'...

well, we could, but it would not be so easy to find out if the change has actually been applied. It would many times be only a guess work...

I believe the warning message should be enough for such a low level feature.
So, Im closing this bug since the warning message is there.