Bug 1479222

Summary: 'command' is a bash builtin
Product: [Fedora] Fedora Reporter: Reto Zingg <g.d0b3rm4n>
Component: barmanAssignee: Dale Macartney <dbmacartney>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: dbmacartney
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-29 11:48:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Reto Zingg 2017-08-08 06:52:27 UTC
Description of problem:

With bash 4.4 barman can't handle the WALs any more correctly while compressing, it fails with:

2017-08-06 14:58:01,774 [2344] barman.cli ERROR: {'ret': 2, 'out': '', 'err': "/bin/sh: `command': is a special builtin\n"}
See log file for more details.
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/barman/cli.py", line 1041, in main
    p.dispatch(pre_call=global_config)
  File "/usr/lib/python3.6/site-packages/argh/helpers.py", line 55, in dispatch
    return dispatch(self, *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/argh/dispatching.py", line 174, in dispatch
    for line in lines:
  File "/usr/lib/python3.6/site-packages/argh/dispatching.py", line 277, in _execute_command
    for line in result:
  File "/usr/lib/python3.6/site-packages/argh/dispatching.py", line 231, in _call
    result = function(namespace_obj)
  File "/usr/lib/python3.6/site-packages/barman/cli.py", line 672, in archive_wal
    server.archive_wal()
  File "/usr/lib/python3.6/site-packages/barman/server.py", line 1408, in archive_wal
    self.backup_manager.archive_wal(verbose)
  File "/usr/lib/python3.6/site-packages/barman/backup.py", line 468, in archive_wal
    archiver.archive(fxlogdb, verbose)
  File "/usr/lib/python3.6/site-packages/barman/wal_archiver.py", line 196, in archive
    self.archive_wal(compressor, wal_info)
  File "/usr/lib/python3.6/site-packages/barman/wal_archiver.py", line 324, in archive_wal
    compressor.compress(src_file, tmp_file)
  File "/usr/lib/python3.6/site-packages/barman/compression.py", line 153, in compress
    return self._compress(src, dst)
  File "/usr/lib/python3.6/site-packages/barman/command_wrappers.py", line 260, in __call__
    self.get_output(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/barman/command_wrappers.py", line 292, in get_output
    return self._get_output_once(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/barman/command_wrappers.py", line 357, in _get_output_once
    self.check_return_value(allowed_retval)
  File "/usr/lib/python3.6/site-packages/barman/command_wrappers.py", line 371, in check_return_value
    ret=self.ret, out=self.out, err=self.err))
barman.exceptions.CommandFailedException: {'ret': 2, 'out': '', 'err': "/bin/sh: `command': is a special builtin\n"}


Version-Release number of selected component (if applicable):
barman-2.1-2.fc26.noarch

How reproducible:
Enable streaming_archiver = on

Steps to Reproduce:
1. run 'barman cron'


Actual results:
see stack trace above

Expected results:
it works, and compresses the wal file

Additional info:
Upstream issue:
https://github.com/2ndquadrant-it/barman/issues/118

Upstream pull-request:
https://github.com/2ndquadrant-it/barman/pull/119

I open this bug in the hope as soon as upstream fixed it, it can also be fixed in the Fedora release.

Even tough the underlying bug is the following bash bug #1479220 I think it makes sense to avoid to use possible builtin command names in scripts and it should be fixed.

Comment 1 Fedora End Of Life 2018-05-03 08:23:07 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 2 Fedora End Of Life 2018-05-29 11:48:42 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.