Bug 1479707

Summary: Review Request: perl-Test-Exit - Test that some code calls exit without terminating testing
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Test-Exit-0.11-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-14 12:54:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1479602    

Description Petr Pisar 2017-08-09 08:51:45 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Test-Exit/perl-Test-Exit.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-Exit/perl-Test-Exit-0.11-1.fc27.src.rpm
Description:
Test::Exit Perl module provides some simple tools for testing code that might
call exit(), providing you with the status code without exiting the test file.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-08-09 10:18:59 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-Exit-0.11-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Return::MultiLevel)
      1 perl(strict)
      1 perl(Test::Builder::Module) >= 0.86
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Exit-0.11-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Test::Exit) = 0.11
      1 perl-Test-Exit = 0.11-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-Exit*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.
Comment 2 Ralph Bean 2017-08-10 17:02:47 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Exit
Comment 3 Ralph Bean 2017-08-10 17:03:38 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Exit
Comment 4 Petr Pisar 2017-08-14 12:54:35 UTC 
Thank you for the review.