Bug 1479868

Summary:	NPE when deactivating Cinder storage domain when no host on UP state
Product:	[oVirt] ovirt-engine	Reporter:	Fred Rolland <frolland>
Component:	BLL.Storage	Assignee:	Fred Rolland <frolland>
Status:	CLOSED DEFERRED	QA Contact:	Avihai <aefrat>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	bugs, ebenahar
Target Milestone:	---	Flags:	pm-rhel: ovirt-4.5?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-01 14:48:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fred Rolland 2017-08-09 15:28:39 UTC

Description of problem:
NullPOinterException when deactivating Cinder storage domain when no host on UP state

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Have a Cinder SD
2. Make all hosts in DC to Down
3. Deactivate Cinder Storage Domain

Actual results:
NPE in log and operation fails

Expected results:
Block the operation on validate.

Additional info:
2017-07-25 17:47:16,574+03 ERROR [org.ovirt.engine.core.bll.storage.domain.DeactivateStorageDomainCommand] (org.ovirt.thread.EE-ManagedThreadFactory-default-Thread-30) [6daa9e04] Exception: java.lang.NullPointerException
	at org.ovirt.engine.core.bll.storage.domain.DeactivateStorageDomainCommand.deactivateCinderStorageDomain(DeactivateStorageDomainCommand.java:375) [bll.jar:]
	at org.ovirt.engine.core.bll.storage.domain.DeactivateStorageDomainCommand.executeCommand(DeactivateStorageDomainCommand.java:257) [bll.jar:]
	at org.ovirt.engine.core.bll.CommandBase.executeWithoutTransaction(CommandBase.java:1259) [bll.jar:]
	at org.ovirt.engine.core.bll.CommandBase.executeActionInTransactionScope(CommandBase.java:1399) [bll.jar:]
	at org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:2075) [bll.jar:]
	at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInSuppressed(TransactionSupport.java:164) [utils.jar:]
	at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:103) [utils.jar:]
	at org.ovirt.engine.core.bll.CommandBase.execute(CommandBase.java:1459) [bll.jar:]
	at org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:410) [bll.jar:]
	at org.ovirt.engine.core.bll.executor.DefaultBackendActionExecutor.execute(DefaultBackendActionExecutor.java:13) [bll.jar:]
	at org.ovirt.engine.core.bll.Backend.runAction(Backend.java:499) [bll.jar:]
	at org.ovirt.engine.core.bll.Backend.runActionImpl(Backend.java:481) [bll.jar:]
	at org.ovirt.engine.core.bll.Backend.runInternalAction(Backend.java:686) [bll.jar:]
	at sun.reflect.GeneratedMethodAccessor392.invoke(Unknown Source) [:1.8.0_131]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_131]
	at java.lang.reflect.Method.invoke(Method.java:498) [rt.jar:1.8.0_131]
	at org.jboss.as.ee.component.ManagedReferenceMethodInterceptor.processInvocation(ManagedReferenceMethodInterceptor.java:52)
	at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
	at org.jboss.invocation.InterceptorContext$Invocation.proceed(InterceptorContext.java:437)
	at org.jboss.as.weld.ejb.Jsr299BindingsInterceptor.delegateInterception(Jsr299BindingsInterceptor.java:70) [wildfly-weld-10.1.0.Final.jar:10.1.0.Final]
	at org.jboss.as.weld.ejb.Jsr299BindingsInterceptor.doMethodInterception(Jsr299BindingsInterceptor.java:80) [wildfly-weld-10.1.0.Final.jar:10.1.0.Final]
	at org.jboss.as.weld.ejb.Jsr299BindingsInterceptor.processInvocation(Jsr299BindingsInterceptor.java:93) [wildfly-weld-10.1.0.Final.jar:10.1.0.Final]
	at org.jboss.as.ee.component.interceptors.UserInterceptorFactory$1.processInvocation(UserInterceptorFactory.java:63)
	at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
	at org.jboss.as.ejb3.component.invocationmetrics.ExecutionTimeInterceptor.processInvocation(ExecutionTimeInterceptor.java:43) [wi

Comment 1 Sandro Bonazzola 2019-01-28 09:37:07 UTC

This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 2 Michal Skrivanek 2020-03-19 15:42:33 UTC

We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it.
If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly.

Comment 3 Michal Skrivanek 2020-04-01 14:48:44 UTC

Closing old bug. Please reopen if still relevant/you want to work on it.